Re: [PATCH] btrfs: remove assertions after btrfs_bio struct changes

["zhen.ni" <zhen.ni@easystack.cn>]

在 2025/12/18 22:05, David Sterba 写道:
> On Thu, Dec 18, 2025 at 02:57:25PM +0100, David Sterba wrote:
>> On Thu, Dec 18, 2025 at 08:22:15PM +0800, Zhen Ni wrote:
>>> Commit 81cea6cd7041 ("btrfs: remove btrfs_bio::fs_info by extracting it
>>> from btrfs_bio::inode") modified the btrfs_bio structure to make the
>>> inode field mandatory, making these assertions redundant:
>>>
>>> - btrfs_check_read_bio(): inode is validated by btrfs_bio_init()
>>> - btrfs_submit_bbio(): condition always passes since inode is never NULL
>>>
>>> Remove these obsolete checks.
>>
>> The assertions may be redundant and their purpose is to catch accidental
>> changes to code or explicitly list some critical assumptions. We'd like
>> to have more rather than fewer of them.
> 
> https://btrfs.readthedocs.io/en/latest/dev/Development-notes.html#handling-unexpected-conditions
> 
> 

Thank you for pointing out the relevant documentation.

Maintaining these assertions (or even adding more) is the better 
approach. They not only prevent current errors but, more importantly, 
prevent future code modifications from introducing problems.