Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RESEND] Revert "btrfs-progs: convert: add raid-stripe-tree to allowed features"
Date: Thu, 13 Jun 2024 06:41:30 +0930	[thread overview]
Message-ID: <2bd8bde3-2314-48fe-b828-6b02820766a1@suse.com> (raw)
In-Reply-To: <20240612194803.GM18508@twin.jikos.cz>



在 2024/6/13 05:18, David Sterba 写道:
> On Mon, Jun 10, 2024 at 06:05:10PM +0930, Qu Wenruo wrote:
>> This reverts commit 346a3819237b319985ad6042d6302f67b040a803.
>>
>> The RST feature (at least for now) is mostly for zoned devices to
>> support extra data profiles.
>>
>> Thus btrfs-convert is never designed to handle RST, because there is no
>> way an ext4/reiserfs can even be created on a zoned device, or it would
>> create the correct RST tree root at all
>>
>> Revert this unsupported feature to prevent false alerts.
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>> ---
>> This was included in the btrfs-convert unwritten extent patchset/pull
>> request but is not merged.
> 
> For the record, RST first use is for zoned device but will allso fix the
> raid56 problems once implemented.

*ONCE* implemented, while it's still hiding behind CONFIG_BTRFS_DEBUG.

> It can be used independently, I don't
> see a reason to remove it's support from convert. Any related test
> failures will be fixed separately.

Nope, I have already argued it again and again, only DEBUG kernel can 
even recognize the RST feature, while you still insists to enable it for 
regular mkfs.

I can not understand your eager to push such an experimental features to 
btrfs-progs meanwhile we have so many things to fix for RST.

Let me to be honest on this, I do not understand why you refuse to even 
move RST to experimental features, when no distro enables 
CONFIG_BTRFS_DEBUG by default.
Thus no 6.9 kernel can even mount a RST btrfs.

I think you're doing an immature decision on RST.

Thanks,
Qu

      reply	other threads:[~2024-06-12 21:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  8:35 [PATCH RESEND] Revert "btrfs-progs: convert: add raid-stripe-tree to allowed features" Qu Wenruo
2024-06-12 19:48 ` David Sterba
2024-06-12 21:11   ` Qu Wenruo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bd8bde3-2314-48fe-b828-6b02820766a1@suse.com \
    --to=wqu@suse.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox