Re: [PATCH 5/7] generic/563: Increase the write tolerance to 6% for larger nodesize

Nirjhar Roy (IBM)
2025-08-04T07:18:09Z

On 7/29/25 13:15, Christoph Hellwig wrote:
> On Tue, Jul 29, 2025 at 06:21:48AM +0000, Nirjhar Roy (IBM) wrote:
>> +# writes, due to increased metadata sizes.
>> +# Hence have a higher write tolerance for btrfs and when
>> +# node size is greater than 4k.
>> +if [[ "$FSTYP" == "btrfs" ]]; then
>> + nodesz=$(_get_btrfs_node_size "$SCRATCH_DEV")
>> + if [[ "$nodesz" -gt 4096 ]]; then
>> + check_cg $cgdir/$seq-cg $iosize $iosize 5% 6%
>> + else
>> + check_cg $cgdir/$seq-cg $iosize $iosize 5% 5%
>> + fi
>> +else
>> + check_cg $cgdir/$seq-cg $iosize $iosize 5% 5%
>> +fi
> Everyone please stop hacking file system specific things into generic
> tests. Add proper core helpers for this instead.

Okay. I will try to work something out. Thank you.

--NR

--
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore