Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Hanabishi <i.r.e.c.c.a.k.u.n+kernel.org@gmail.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix creation of compressed inline extents that don't save space
Date: Mon, 14 Sep 2026 18:15:05 +0000	[thread overview]
Message-ID: <2efcc9e0-e056-4f23-ac82-4b7c776582ea@gmail.com> (raw)
In-Reply-To: <721d8fd2c73095d06cbdbfa714a6dfac9c488953.1789407346.git.fdmanana@suse.com>

> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index a85a7c561cf8..420d78b55bba 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -2339,7 +2339,7 @@ static int run_delalloc_inline(struct btrfs_inode *inode, struct folio *locked_f
>   		} else if (inode->prop_compress) {
>   			compress_type = inode->prop_compress;
>   		}
> -		cb = btrfs_compress_bio(inode, 0, blocksize, compress_type, compress_level, 0);
> +		cb = btrfs_compress_bio(inode, 0, i_size, compress_type, compress_level, 0);
>   		if (IS_ERR(cb)) {
>   			cb = NULL;
>   			/* Just fall back to non-compressed case. */

Yep, this works. 👍️


  reply	other threads:[~2026-09-14 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 17:36 [PATCH] btrfs: fix creation of compressed inline extents that don't save space fdmanana
2026-09-14 18:15 ` Hanabishi [this message]
2026-09-14 18:46 ` [PATCH v2] " fdmanana
2026-09-14 19:40 ` [PATCH v3] " fdmanana
2026-09-14 21:33   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2efcc9e0-e056-4f23-ac82-4b7c776582ea@gmail.com \
    --to=i.r.e.c.c.a.k.u.n+kernel.org@gmail.com \
    --cc=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox