Re: [PATCH 0/3] Misc cleanups to cached extent

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

On 2018年05月04日 15:47, Nikolay Borisov wrote:
> Here are a couple of cleanups I stumbled upon while looking at the freespace 
> validation code. The first one simplifies btrfs_rmap_block that has an unused 
> parameter. The next 2 patches cleanup the cache_extent apis since they provide
> more than we are actually using (or have ever used).

Under all cases, only insert_cache_extent2() is used, so removing
add_cache_extent2() is completely fine.

> Nikolay Borisov (3):
>   btrfs-progs: Remove devid parameter from btrfs_rmap_block
>   btrfs-progs: Remove add_cache_extent2
>   btrfs-progs: Remove objectid argument from alloc_cache_extent

All of them looks good.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> 
>  check/main.c   |  2 +-
>  extent-cache.c | 21 ++++-----------------
>  extent-cache.h |  2 --
>  extent-tree.c  | 10 +++++-----
>  volumes.c      |  7 ++-----
>  volumes.h      |  4 ++--
>  6 files changed, 14 insertions(+), 32 deletions(-)
>