From: Anand Jain <anand.jain@oracle.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: qgroup: do quick checks if quotas are enabled before starting ioctls
Date: Tue, 7 May 2024 05:37:52 +0800 [thread overview]
Message-ID: <2f59d22a-9f9e-41b2-b086-de98fa67bac5@oracle.com> (raw)
In-Reply-To: <20240502211133.20102-1-dsterba@suse.com>
On 5/3/24 05:11, David Sterba wrote:
> The ioctls that add relations, create qgroups or set limits start/join
> transaction. When quotas are not enabled this is not necessary, there
> will be errors reported back anyway but this could be also misleading
> and we should really report that quotas are not enabled. For that use
> -ENOTCONN.
>
> The helper is meant to do a quick check before any other standard ioctl
> checks are done. If quota is disabled meanwhile we still rely on proper
> locking inside any active operation changing the qgroup structures.
>
> Signed-off-by: David Sterba <dsterba@suse.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
prev parent reply other threads:[~2024-05-06 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:11 [PATCH] btrfs: qgroup: do quick checks if quotas are enabled before starting ioctls David Sterba
2024-05-06 21:37 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f59d22a-9f9e-41b2-b086-de98fa67bac5@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox