Re: [PATCH v2] btrfs: Rework error detection in init_tree_roots

[Nikolay Borisov <nborisov@suse.com>]

On 12.08.20 г. 16:16 ч., Nikolay Borisov wrote:
> To avoid duplicating 3 lines of code the error detection logic in
> init_tree_roots is somewhat quirky. It first checks for the presence of
> any error condition, then checks for the specific condition to perform
> any specific actions. That's spurious because directly checking for
> each respective error condition and doing the necessary steps is more
> obvious. While at it change the -EUCLEAN to -EIO in case the extent
> buffer is not read correctly, this is in line with other sites which
> return -EIO when the eb couldn't be read.
> 
> Additionally it results in smaller code and the code reads
> more linearly:
> 
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-95 (-95)
> Function                                     old     new   delta
> open_ctree                                 17243   17148     -95
> Total: Before=113104, After=113009, chg -0.08%
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> 
> Changes in v2:
> * Return -EIO in case of !extent_buffer_uptodate
> * Change the error messages to distinguish both cases albeit they are still
> rather similar.

Any comments on V2 ?