From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 2/2] btrfs-progs: tests: return metadata_uuid or fsid as per METADATA_UUID flag
Date: Thu, 20 Jul 2023 17:03:57 +0800 [thread overview]
Message-ID: <30c59990140b572b0336effd2ae1902c7e07ffa8.1689841911.git.anand.jain@oracle.com> (raw)
In-Reply-To: <cover.1689841911.git.anand.jain@oracle.com>
Commit
btrfs-progs: dump-super print actual metadata_uuid value
fixed the value of the super_block::metadata_uuid to be printed as it
is, without tweaking it depending on the METADATA_UUID flag.
Apply similar counter tweak in the common helper functions used to read
the metadata_uuid so that test-cases still be successful.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
tests/misc-tests/034-metadata-uuid/test.sh | 24 +++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/tests/misc-tests/034-metadata-uuid/test.sh b/tests/misc-tests/034-metadata-uuid/test.sh
index 77a310d54f0f..dba31db90368 100755
--- a/tests/misc-tests/034-metadata-uuid/test.sh
+++ b/tests/misc-tests/034-metadata-uuid/test.sh
@@ -15,6 +15,19 @@ if [ ! -f /sys/fs/btrfs/features/metadata_uuid ] ; then
_not_run "METADATA_UUID feature not supported"
fi
+has_metadata_uuid_flag() {
+ local dev="$1"
+
+ run_check_stdout $SUDO_HELPER "$TOP/btrfs" inspect-internal \
+ dump-super "$dev" | egrep -q METADATA_UUID
+
+ if [ $? -eq 0 ]; then
+ echo true
+ else
+ echo false
+ fi
+}
+
read_fsid() {
local dev="$1"
@@ -24,9 +37,14 @@ read_fsid() {
read_metadata_uuid() {
local dev="$1"
-
- echo $(run_check_stdout $SUDO_HELPER "$TOP/btrfs" inspect-internal \
- dump-super "$dev" | awk '/metadata_uuid/ {print $2}')
+ local flag=$(has_metadata_uuid_flag $dev)
+
+ if [ "$flag" == "true" ]; then
+ echo $(run_check_stdout $SUDO_HELPER "$TOP/btrfs" inspect-internal \
+ dump-super "$dev" | awk '/metadata_uuid/ {print $2}')
+ else
+ read_fsid $dev
+ fi
}
check_btrfstune() {
--
2.39.3
WARNING: multiple messages have this Message-ID (diff)
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 2/2] btrfs-progs: tests: return metadata_uuid or fsid as per METADATA_UUID flag
Date: Tue, 25 Jul 2023 16:24:14 +0800 [thread overview]
Message-ID: <30c59990140b572b0336effd2ae1902c7e07ffa8.1689841911.git.anand.jain@oracle.com> (raw)
Message-ID: <20230725082414._E0ArvDI4i1dHLdZPdcLuN3x-czptBTf2NPnuzCFbb4@z> (raw)
In-Reply-To: <cover.1689841911.git.anand.jain@oracle.com>
Commit
btrfs-progs: dump-super print actual metadata_uuid value
fixed the value of the super_block::metadata_uuid to be printed as it
is, without tweaking it depending on the METADATA_UUID flag.
Apply similar counter tweak in the common helper functions used to read
the metadata_uuid so that test-cases still be successful.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
tests/misc-tests/034-metadata-uuid/test.sh | 24 +++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/tests/misc-tests/034-metadata-uuid/test.sh b/tests/misc-tests/034-metadata-uuid/test.sh
index 77a310d54f0f..dba31db90368 100755
--- a/tests/misc-tests/034-metadata-uuid/test.sh
+++ b/tests/misc-tests/034-metadata-uuid/test.sh
@@ -15,6 +15,19 @@ if [ ! -f /sys/fs/btrfs/features/metadata_uuid ] ; then
_not_run "METADATA_UUID feature not supported"
fi
+has_metadata_uuid_flag() {
+ local dev="$1"
+
+ run_check_stdout $SUDO_HELPER "$TOP/btrfs" inspect-internal \
+ dump-super "$dev" | egrep -q METADATA_UUID
+
+ if [ $? -eq 0 ]; then
+ echo true
+ else
+ echo false
+ fi
+}
+
read_fsid() {
local dev="$1"
@@ -24,9 +37,14 @@ read_fsid() {
read_metadata_uuid() {
local dev="$1"
-
- echo $(run_check_stdout $SUDO_HELPER "$TOP/btrfs" inspect-internal \
- dump-super "$dev" | awk '/metadata_uuid/ {print $2}')
+ local flag=$(has_metadata_uuid_flag $dev)
+
+ if [ "$flag" == "true" ]; then
+ echo $(run_check_stdout $SUDO_HELPER "$TOP/btrfs" inspect-internal \
+ dump-super "$dev" | awk '/metadata_uuid/ {print $2}')
+ else
+ read_fsid $dev
+ fi
}
check_btrfstune() {
--
2.39.3
next prev parent reply other threads:[~2023-07-20 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 8:50 [PATCH 0/2] btrfs-progs: fix dump-super metadata_uuid Anand Jain
2023-07-20 8:50 ` [PATCH 1/2] btrfs-progs: dump-super print actual metadata_uuid value Anand Jain
2023-07-20 9:03 ` Anand Jain
2023-07-25 8:24 ` Anand Jain
2023-07-20 9:03 ` [PATCH 0/2] btrfs-progs: fix dump-super metadata_uuid Anand Jain
2023-07-20 9:03 ` Anand Jain [this message]
2023-07-25 8:24 ` [PATCH 2/2] btrfs-progs: tests: return metadata_uuid or fsid as per METADATA_UUID flag Anand Jain
2023-07-25 8:24 ` [PATCH 0/2] btrfs-progs: fix dump-super metadata_uuid Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30c59990140b572b0336effd2ae1902c7e07ffa8.1689841911.git.anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).