Re: [PATCH 7/7] btrfs: remove the subpage related warning message

[Qu Wenruo <wqu@suse.com>]

在 2025/2/26 04:40, Filipe Manana 写道:
> On Sun, Feb 23, 2025 at 11:47 PM Qu Wenruo <wqu@suse.com> wrote:
>>
>> Since the initial enablement of block size < page size support for
>> btrfs in v5.15, we have hit several milestones for block size < page
>> size (subpage) support:
>>
>> - RAID56 subpage support
>>    In v5.19
>>
>> - Refactored scrub support to support subpage better
>>    In v6.4
>>
>> - Block perfect (previously requires page aligned ranges) compressed write
>>    In v6.13
>>
>> - Various error handling fixes involving subpage
>>    In v6.14
>>
>> Finally the only missing feature is the pretty simple and harmless
>> inlined data extent creation, just done in previous patches.
>>
>> Now btrfs has all of its features ready for both regular and subpage
>> cases, there is no reason to output a warning about the experimental
>> subpage support, and we can finally remove it now.
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
> 
> I don't have a machine to test block size < page size, but I trust you
> did all the testing besides being the expert on the code base for the
> feature, so:

There will a be a very small patch series (3 patches, < 70 lines of 
modification), to enable 2K block size on DEBUG btrfs builds.

Although with a lot of extra limitations, it should be enough to trigger 
most (if not all) bugs involved in this series.

The fstests to avoid the 2K block size limit will be a much big work 
though...

Thanks,
Qu

> 
> Acked-by: Filipe Manana <fdmanana@suse.com>
> 
> Thanks.
> 
>> ---
>>   fs/btrfs/disk-io.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
>> index a799216aa264..c0b40dedceb5 100644
>> --- a/fs/btrfs/disk-io.c
>> +++ b/fs/btrfs/disk-io.c
>> @@ -3414,11 +3414,6 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
>>           */
>>          fs_info->max_inline = min_t(u64, fs_info->max_inline, fs_info->sectorsize);
>>
>> -       if (sectorsize < PAGE_SIZE)
>> -               btrfs_warn(fs_info,
>> -               "read-write for sector size %u with page size %lu is experimental",
>> -                          sectorsize, PAGE_SIZE);
>> -
>>          ret = btrfs_init_workqueues(fs_info);
>>          if (ret)
>>                  goto fail_sb_buffer;
>> --
>> 2.48.1
>>
>>