From: Martin Steigerwald <martin@lichtvoll.de>
To: linux-btrfs@vger.kernel.org, Qu Wenruo <wqu@suse.com>
Subject: Re: [PATCH RFC 0/4] btrfs: scrub: make sctx->stripes[] a ring buffer
Date: Wed, 19 Jul 2023 08:44:08 +0200 [thread overview]
Message-ID: <3191260.5fSG56mABF@lichtvoll.de> (raw)
In-Reply-To: <2250219.iZASKD2KPV@lichtvoll.de>
Martin Steigerwald - 19.07.23, 08:34:51 CEST:
> Qu Wenruo - 19.07.23, 07:30:22 CEST:
> > This is the attempt to increase the queue depth of the scrub
> > behavior.
[…]
> > Thus this patch is mostly sent asking for better ideas.
>
> Hmm, another approach would be to revert the patches that introduced
> the performance regression. It would release the pressure to find a
> fix soon. Then you'd have all the time to have another go at
> improving scrubbing. At least the issue at hand seems to be tricky.
>
> What you think?
Sorry, missed that you posted another patch later. So just ignore this
idea.
Thanks,
--
Martin
prev parent reply other threads:[~2023-07-19 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 5:30 [PATCH RFC 0/4] btrfs: scrub: make sctx->stripes[] a ring buffer Qu Wenruo
2023-07-19 5:30 ` [PATCH RFC 1/4] btrfs: scrub: move write back of repaired sectors into scrub_stripe_read_repair_worker() Qu Wenruo
2023-07-19 5:30 ` [PATCH RFC 2/4] btrfs: scrub: don't go ordered workqueue for dev-replace Qu Wenruo
2023-07-19 5:30 ` [PATCH RFC 3/4] btrfs: scrub: use btrfs workqueue to synchronize the write back " Qu Wenruo
2023-07-19 5:30 ` [PATCH RFC 4/4] btrfs: scrub: make sctx->stripes[] array work as a ring buffer Qu Wenruo
2023-07-28 3:15 ` kernel test robot
2023-07-19 6:34 ` [PATCH RFC 0/4] btrfs: scrub: make sctx->stripes[] " Martin Steigerwald
2023-07-19 6:44 ` Martin Steigerwald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3191260.5fSG56mABF@lichtvoll.de \
--to=martin@lichtvoll.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox