Re: [PATCH 10/11] btrfs: btrfs_dev_replace_update_device_in_mapping_tree drop file global declare

Nikolay Borisov
2020-08-31T08:46:12Z

On 30.08.20 г. 17:41 ч., Anand Jain wrote:
> There isn't any convoluted child functions inside the
> btrfs_dev_replace_update_device_in_mapping_tree() function. With the
> function moved before where it is called, we can drop its file local
> declare.
>
> No functional changes.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>

I personally am fan of such refactoring but I remember David didn't like
them so much on their own, still:

Reviewed-by: Nikolay Borisov <nborisov@suse.com>