From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] btrfs: make qgroup rescan work to handle fs freezing
Date: Tue, 22 Sep 2026 07:18:59 +0930 [thread overview]
Message-ID: <3259c715-8fd1-4644-abaf-6d983295d559@gmx.com> (raw)
In-Reply-To: <20260921131844.GF54722@twin.jikos.cz>
在 2026/9/21 22:48, David Sterba 写道:
> On Mon, Sep 21, 2026 at 06:46:45PM +0930, Qu Wenruo wrote:
>> --- a/fs/btrfs/transaction.c
>> +++ b/fs/btrfs/transaction.c
>> @@ -559,7 +559,7 @@ static bool may_wait_transaction(struct btrfs_fs_info *fs_info, int type)
>> if (test_bit(BTRFS_FS_LOG_RECOVERING, &fs_info->flags))
>> return false;
>>
>> - if (type == TRANS_START)
>> + if ((type & TRANS_START) == TRANS_START)
>
> This does not seem right, the type should be a single number, not a
> bitmask
But TRANS_START is already defined as a bitmask.
>
>> #define TRANS_START (__TRANS_START | __TRANS_FREEZABLE)
>> +#define TRANS_TRY_START (__TRANS_START | __TRANS_FREEZABLE | __TRANS_TRYLOCK)
>
> If you meant to distinguish normal start and 'try' start then it's check
> for two values.
So what your recommended change?
next prev parent reply other threads:[~2026-09-21 21:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 9:16 [PATCH v2 0/3] btrfs: make qgroup rescan work to handle fs freezing Qu Wenruo
2026-09-21 7:03 ` [PATCH] " Qu Wenruo
2026-09-21 8:36 ` Dongjiang Zhu
2026-09-21 13:12 ` David Sterba
2026-09-21 13:34 ` Dongjiang Zhu
2026-09-21 21:46 ` Qu Wenruo
2026-09-22 6:30 ` Andrei Borzenkov
2026-09-22 6:57 ` Qu Wenruo
2026-09-22 6:24 ` Andrei Borzenkov
2026-09-21 9:16 ` Qu Wenruo
2026-09-21 13:18 ` David Sterba
2026-09-21 21:48 ` Qu Wenruo [this message]
2026-09-21 9:16 ` [PATCH v2 1/3] btrfs: let rescan_should_stop() decide if the rescan flag is cleared Qu Wenruo
2026-09-21 10:14 ` Dongjiang Zhu
2026-09-21 10:26 ` Qu Wenruo
2026-09-21 10:39 ` Dongjiang Zhu
2026-09-21 9:16 ` [PATCH v2 2/3] btrfs: always show the message when qgroup rescan ended Qu Wenruo
2026-09-21 9:16 ` [PATCH v2 3/3] btrfs: make qgroup rescan work handle fs freezing Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3259c715-8fd1-4644-abaf-6d983295d559@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=richard@nod.at \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox