From: Nikolay Borisov <nborisov@suse.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/8] btrfs: make btrfs_check_super_csum() non-static
Date: Tue, 27 Mar 2018 15:10:33 +0300 [thread overview]
Message-ID: <3337e0a0-432c-2f39-f084-10162431e0cb@suse.com> (raw)
In-Reply-To: <20180326082742.9235-5-anand.jain@oracle.com>
On 26.03.2018 11:27, Anand Jain wrote:
> In preparation to add the superblock csum verification for the
> scan context, make btrfs_check_super_csum() non-static.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/disk-io.c | 2 +-
> fs/btrfs/disk-io.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 8b4e602ed60a..6299ab18da5f 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -395,7 +395,7 @@ static int verify_parent_transid(struct extent_io_tree *io_tree,
> * Otherwise: -EINVAL if csum type is not found
> * -EUCLEAN if csum does not match
> */
> -static int btrfs_check_super_csum(char *raw_disk_sb)
> +int btrfs_check_super_csum(char *raw_disk_sb)
> {
> struct btrfs_super_block *disk_sb =
> (struct btrfs_super_block *)raw_disk_sb;
> diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h
> index 70a88d61b547..c400cc68f913 100644
> --- a/fs/btrfs/disk-io.h
> +++ b/fs/btrfs/disk-io.h
> @@ -69,6 +69,7 @@ int write_all_supers(struct btrfs_fs_info *fs_info, int max_mirrors);
> struct buffer_head *btrfs_read_dev_super(struct block_device *bdev);
> int btrfs_read_dev_one_super(struct block_device *bdev, int copy_num,
> struct buffer_head **bh_ret);
> +int btrfs_check_super_csum(char *raw_disk_sb);
> int btrfs_commit_super(struct btrfs_fs_info *fs_info);
> struct btrfs_root *btrfs_read_fs_root(struct btrfs_root *tree_root,
> struct btrfs_key *location);
>
next prev parent reply other threads:[~2018-03-27 12:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 8:27 [PATCH 0/8] Superblock read and verify cleanups Anand Jain
2018-03-26 8:27 ` [PATCH 1/8] btrfs: cleanup btrfs_check_super_csum() for better code flow Anand Jain
2018-03-27 12:10 ` Nikolay Borisov
2018-03-26 8:27 ` [PATCH 2/8] btrfs: return required error from btrfs_check_super_csum Anand Jain
2018-03-27 8:05 ` Nikolay Borisov
2018-03-27 19:16 ` David Sterba
2018-03-27 20:43 ` Anand Jain
2018-04-05 14:48 ` David Sterba
2018-03-26 8:27 ` [PATCH 3/8] btrfs: cleanup btrfs_read_disk_super() to return std error Anand Jain
2018-03-27 8:07 ` Nikolay Borisov
2018-03-26 8:27 ` [PATCH 4/8] btrfs: make btrfs_check_super_csum() non-static Anand Jain
2018-03-27 12:10 ` Nikolay Borisov [this message]
2018-03-26 8:27 ` [PATCH 5/8] btrfs: check if the fsid in the primary sb and copy sb are same Anand Jain
2018-03-27 8:49 ` Nikolay Borisov
2018-03-27 22:06 ` Anand Jain
2018-03-28 6:08 ` Nikolay Borisov
2018-03-28 7:05 ` Anand Jain
2018-03-26 8:27 ` [PATCH 6/8] btrfs: verify checksum when superblock is read for scan Anand Jain
2018-03-27 11:30 ` Nikolay Borisov
2018-03-27 12:09 ` Nikolay Borisov
2018-03-27 23:01 ` Anand Jain
2018-03-28 6:12 ` Nikolay Borisov
2018-03-26 8:27 ` [PATCH 7/8] btrfs: verify checksum for all devices in mount context Anand Jain
2018-03-27 12:21 ` Nikolay Borisov
2018-03-27 22:48 ` Anand Jain
2018-03-26 8:27 ` [PATCH 8/8] btrfs: drop the redundant invalidate_bdev() Anand Jain
-- strict thread matches above, loose matches on Subject: below --
2018-03-27 23:39 [PATCH v2 0/9] Superblock read and verify cleanups Anand Jain
2018-03-27 23:39 ` [PATCH 4/8] btrfs: make btrfs_check_super_csum() non-static Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3337e0a0-432c-2f39-f084-10162431e0cb@suse.com \
--to=nborisov@suse.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).