Re: [PATCH 1/3] btrfs: get rid of path allocation in btrfs_del_inode_extref()

Sun YangKai
2025-04-15T14:45:14Z

It seems a nice try to reduce path allocation and improve performance.

But it also seems make the code less maintainable. I would prefer to have a
comment saying something like the @path argument is just for reuse the
btrfs_path allocation and only a released or empty btrfs_path should be used
here.

Also, although the path passed is released, it seems the bit flags are still
passed, which makes the behavior of the functions a little different. But it
seems fine since those bit flags are never set in this code path.