linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Della Bianca <giusdbg@gmail.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [COMMAND HANGS] The command 'btrfs subvolume sync -s 2 xyz' can hangs.
Date: Tue, 08 Jan 2019 22:55:36 +0100	[thread overview]
Message-ID: <34407090.HkA8NDud7j@exnet.gdb.it> (raw)
In-Reply-To: <04891508-41fd-9d63-9dfb-a51041a3b8ea@suse.com>

In data martedì 8 gennaio 2019 22:18:11 CET, Jeff Mahoney ha scritto:

]zac[
> Thanks.  As it turns out, since Filipe's identified the fix for this
> issue, we don't need it anymore.  If that turns out to be a different
> issue, we can revisit the log.

Ok.

]zac[
> > I don't know how btrfs works inside.
> > I just suppose that somewhere in the code an error state is not handled
> > correctly (which can be a file or the whole filesystem not accessible).
> 
> Kind of, if you look at it under the right light.  The sync subcommand
> only waits for the lookup for the subvolume undergoing deletion to not
> be there anymore.  There's no error state to be passed back to the
> waiter, only the initiator.
]zac[

I understand.
But this is a design error in error handling.
The sync subcommand should also check a flag that the deletion system could 
set in case it is no longer possible to continue the deletion.


Gdb




  reply	other threads:[~2019-01-08 21:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 15:15 [COMMAND HANGS] The command 'btrfs subvolume sync -s 2 xyz' can hangs Giuseppe Della Bianca
2018-08-09 18:48 ` Jeff Mahoney
2018-08-10 16:57   ` Giuseppe Della Bianca
2019-01-01 16:37   ` Giuseppe Della Bianca
2019-01-04 20:34     ` Jeff Mahoney
2019-01-05 12:30       ` Giuseppe Della Bianca
2019-01-06 14:12         ` Qu Wenruo
2019-01-06 17:57           ` Giuseppe Della Bianca
2019-01-06 23:55             ` Qu Wenruo
     [not found]               ` <CAO6awePqby834dBSgLx5r6onmD9HhGWAfN4bno0zK6pU0QjrEQ@mail.gmail.com>
2019-01-07 12:55                 ` Fwd: " gius db
2019-01-07 13:31                   ` Qu Wenruo
     [not found]                     ` <CAO6aweMu9HUn34406Kkh-UvoDyoJH2ZdGUQx3vdx1Rj955E4KQ@mail.gmail.com>
2019-01-07 17:53                       ` Fwd: " gius db
2019-01-07 22:40         ` Jeff Mahoney
2019-01-08 21:02           ` Giuseppe Della Bianca
2019-01-08 21:18             ` Jeff Mahoney
2019-01-08 21:55               ` Giuseppe Della Bianca [this message]
2019-01-07 23:11     ` Filipe Manana
2019-01-08 12:14       ` gius db
2019-01-08 12:29         ` Filipe Manana
2019-01-08 13:01           ` gius db

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34407090.HkA8NDud7j@exnet.gdb.it \
    --to=giusdbg@gmail.com \
    --cc=jeffm@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).