Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
Cc: Zooko Wilcox-OHearn <zooko@leastauthority.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: fs corruption report
Date: Thu, 04 Sep 2014 11:50:14 +0200	[thread overview]
Message-ID: <3487607.QJCBo4siRK@fb07-iapwap2> (raw)
In-Reply-To: <1409799655.13046.16.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]

Hello Guy,

Am Donnerstag, 4. September 2014, 11:00:55 schrieb Gui Hecheng:
> On Mon, 2014-09-01 at 15:25 +0000, Zooko Wilcox-OHearn wrote:
> > I'm more than happy to try out patches and even focus my own brain on
> > diagnosing it, if I can. I'm hoping to regain access to some of my
> > files on my btrfs partition, and also I would enjoy helping get this
> > improved. :-)
> > 
> > So if you want me to try an experiment, just email me. Unfortunately I
> > can't just give you a copy of the partition, since it has confidential
> > information on it.
> > 
> > Regards,
> > 
> > Zooko
> 
> Hi Zooko, Marc,
> 
> Firstly, thanks for your backtrace info, Marc.
> Sorry to reply late, since I'm offline these days.
> For the restore problem, I'm sure that the lzo decompress routine lacks
> the ability to handle some specific extent pattern.
> 
> Here is my test result:
> I'm using a specific file for test
> /usr/lib/modules/$(uname -r)/kernel/net/irda/irda.ko.
> You can get it easily on your own box.
> 
> 	# mkfs -t btrfs <dev>
> 	# mount -o compress-force=lzo <dev> <mnt>
> 	# cp irda.ko <mnt>
> 	# umount <dev>
> 	# btrfs restore -v <dev> <restore_dir>
> report:
> 	# bad compress length
> 	# failed to inflate

uh, that's really odd. I don't use force compress, but I guess it will also 
happen with non-forced one if the file is big enough.

> btrfs-progs version: v3.16.x
> 
> With the same file under no-compress & zlib-compress,
> the restore will output a correct copy of irda.ko.
> 
> I'm not sure whether the problem above has something to do with your
> problem. Hope that the messages above are helpful.

I also get lot's of "bad compress length", so it might be indeed related.

I'm not a programmer, but is it possible that we are just skipping the lzo 
header (magic + header len + rest of header)?

Thanks,

Marc

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2014-09-04  9:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25  5:08 fs corruption report Zooko Wilcox-OHearn
2014-08-28  2:28 ` Gui Hecheng
2014-09-01  8:47   ` Marc Dietrich
2014-09-01  9:09     ` Marc Dietrich
2014-09-01 15:25       ` Zooko Wilcox-OHearn
2014-09-04  3:00         ` Gui Hecheng
2014-09-04  9:50           ` Marc Dietrich [this message]
2014-09-12 12:35             ` Marc Dietrich
2014-09-18  3:39         ` Gui Hecheng
2014-09-18  8:16           ` Marc Dietrich
2014-09-18 12:47             ` Zooko Wilcox-OHearn
2014-09-19  1:30               ` Gui Hecheng
2014-09-22  8:19                 ` Marc Dietrich
2014-09-22  8:33                   ` Gui Hecheng
2014-09-22  8:49                     ` Marc Dietrich
2014-09-22  8:55                       ` Gui Hecheng
2014-09-22 15:05                 ` Zooko Wilcox-OHearn
2014-08-28  2:46 ` Gui Hecheng
2014-08-28  3:23   ` Chris Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3487607.QJCBo4siRK@fb07-iapwap2 \
    --to=marvin24@gmx.de \
    --cc=guihc.fnst@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=zooko@leastauthority.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox