Re: [PATCH] btrfs: qgroup: move the qgroup->members check out from (!qgroup)'s else branch

[Nikolay Borisov <nborisov@suse.com>]

On 11.10.2018 08:42, Lu Fengqi wrote:
> There is no reason to put this check in (!qgroup)'s else branch because if
> qgroup is null, it will goto out directly. So move it out to reduce
> indent.
> 
> No Functional Change.
> 
> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  fs/btrfs/qgroup.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index 27f517315388..af65ab1640b0 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -1416,13 +1416,14 @@ int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, u64 qgroupid)
>  	if (!qgroup) {
>  		ret = -ENOENT;
>  		goto out;
> -	} else {
> -		/* check if there are no children of this qgroup */
> -		if (!list_empty(&qgroup->members)) {
> -			ret = -EBUSY;
> -			goto out;
> -		}
>  	}
> +
> +	/* check if there are no children of this qgroup */
> +	if (!list_empty(&qgroup->members)) {
> +		ret = -EBUSY;
> +		goto out;
> +	}
> +
>  	ret = del_qgroup_item(trans, qgroupid);
>  	if (ret && ret != -ENOENT)
>  		goto out;
>