From: Pavel Begunkov <asml.silence@gmail.com>
To: Mark Harmstone <maharmstone@fb.com>, linux-btrfs@vger.kernel.org
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH 1/2] io_uring/cmd: let cmds to know about dying task
Date: Mon, 4 Nov 2024 00:13:56 +0000 [thread overview]
Message-ID: <35cdcdbf-aebb-4928-9ebd-e5123881c116@gmail.com> (raw)
In-Reply-To: <20241031163257.3616106-1-maharmstone@fb.com>
On 10/31/24 16:32, Mark Harmstone wrote:
...
> struct io_wq_work_node {
> diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
> index 39c3c816ec78..78a8ba5d39ae 100644
> --- a/io_uring/uring_cmd.c
> +++ b/io_uring/uring_cmd.c
> @@ -119,9 +119,13 @@ EXPORT_SYMBOL_GPL(io_uring_cmd_mark_cancelable);
> static void io_uring_cmd_work(struct io_kiocb *req, struct io_tw_state *ts)
> {
> struct io_uring_cmd *ioucmd = io_kiocb_to_cmd(req, struct io_uring_cmd);
> + unsigned int flags = IO_URING_F_COMPLETE_DEFER;
> +
> + if (req->task != current)
> + flags |= IO_URING_F_TASK_DEAD;
Actually, the patch is broken. I have no clue why Bernd changed
it and left my name, here was the original:
https://lore.kernel.org/io-uring/d2528a1c-3d7c-4124-953c-02e8e415529e@gmail.com/
also now it'll also conflict with patches Jens is queuing, I'll send
a replacement btrfs can take.
--
Pavel Begunkov
prev parent reply other threads:[~2024-11-04 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 16:32 [PATCH 1/2] io_uring/cmd: let cmds to know about dying task Mark Harmstone
2024-11-01 3:14 ` Ming Lei
2024-11-03 22:01 ` Pavel Begunkov
2024-11-04 0:13 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35cdcdbf-aebb-4928-9ebd-e5123881c116@gmail.com \
--to=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=maharmstone@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox