From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [DOC] BTRFS Volume operations, Device Lists and Locks all in one page
Date: Fri, 13 Jul 2018 15:24:04 +0800 [thread overview]
Message-ID: <369f812e-b82a-a0f7-a6b1-b5259d24a728@oracle.com> (raw)
In-Reply-To: <a5635255-2aaa-7091-8723-93912ff126dd@gmx.com>
On 07/13/2018 01:39 PM, Qu Wenruo wrote:
>
>
> On 2018年07月13日 13:32, Anand Jain wrote:
>>
>>
>>
>>
>>
>>>> But if you are planning to
>>>> record and start at transaction [14] then its an overkill because
>>>> transaction [19 and [20] are already in the disk.
>>>
>>> Yes, I'm doing it overkilled.
>>
>> Ah. Ok.
>>
>>> But it's already much better than scrub all block groups (my original
>>> plan).
>>
>> That's true. Which can be optimized later, but how? and scrub can't
>> fix RAID1.
>
> How could scrub not fix RAID1?
Because degraded RAID1 allocates and writes data to the single chunks.
There is no mirrored copy of these data and it would remain as it is
even after the scrub.
> For metadata or data with csum, just goes normal scrub.
Still need to fix the generation check for bg/parent transit
verification across the trees/disks part. IMO.
> For data without csum, we know which device is resilvering, just use the
> other copy.
If its a short term fix then its ok. But I think the approach is
similar to Liubo's InSync patch. Problem with this is, we will fail
to recover any data when the good disk throws media errors.
Thanks, Anand
> Thanks,
> Qu
>
>>
>> Thanks, Anand
>>
>>
>>> Thanks,
>>> Qu
>>>
>>>>
>>>> Thanks, Anand
>>>>
>>>>
>>>>> Thanks,
>>>>> Qu
>>>>>
>>>>>> [3] https://patchwork.kernel.org/patch/10403311/
>>>>>>
>>>>>> Further, as we do a self adapting chunk allocation in RAID1, it
>>>>>> needs
>>>>>> balance-convert to fix. IMO at some point we have to provide
>>>>>> degraded
>>>>>> raid1 chunk allocation and also modify the scrub to be chunk
>>>>>> granular.
>>>>>>
>>>>>> Thanks, Anand
>>>>>>
>>>>>>> Any idea on this?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Qu
>>>>>>>
>>>>>>>> Unlock: btrfs_fs_info::chunk_mutex
>>>>>>>> Unlock: btrfs_fs_devices::device_list_mutex
>>>>>>>>
>>>>>>>> -----------------------------------------------------------------------
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Thanks, Anand
>>>>>>>> --
>>>>>>>> To unsubscribe from this list: send the line "unsubscribe
>>>>>>>> linux-btrfs" in
>>>>>>>> the body of a message to majordomo@vger.kernel.org
>>>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>>>
>>>>>> --
>>>>>> To unsubscribe from this list: send the line "unsubscribe
>>>>>> linux-btrfs" in
>>>>>> the body of a message to majordomo@vger.kernel.org
>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe
>>>> linux-btrfs" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>
next prev parent reply other threads:[~2018-07-13 7:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 7:50 [DOC] BTRFS Volume operations, Device Lists and Locks all in one page Anand Jain
2018-07-12 5:43 ` Qu Wenruo
2018-07-12 12:33 ` Anand Jain
2018-07-12 12:59 ` Qu Wenruo
2018-07-12 16:44 ` Anand Jain
2018-07-13 0:20 ` Qu Wenruo
2018-07-13 2:07 ` Qu Wenruo
2018-07-13 5:32 ` Anand Jain
2018-07-13 5:39 ` Qu Wenruo
2018-07-13 7:24 ` Anand Jain [this message]
2018-07-13 7:41 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=369f812e-b82a-a0f7-a6b1-b5259d24a728@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).