From: Nikolay Borisov <nborisov@suse.com>
To: Filipe Manana <fdmanana@kernel.org>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] Btrfs: remove pointless assertion on reclaim_size counter
Date: Tue, 7 Apr 2020 18:01:56 +0300 [thread overview]
Message-ID: <37df657f-b61d-e1a6-ddb5-72cd421e8cb8@suse.com> (raw)
In-Reply-To: <CAL3q7H45q8Ct_SOO1-zzrGHcDAS4yFeEoQc+8CgzbLPG2miBPw@mail.gmail.com>
On 7.04.20 г. 17:14 ч., Filipe Manana wrote:
> On Tue, Apr 7, 2020 at 12:32 PM Nikolay Borisov <nborisov@suse.com> wrote:
>>
>>
>>
>> On 7.04.20 г. 13:38 ч., fdmanana@kernel.org wrote:
>>> From: Filipe Manana <fdmanana@suse.com>
>>>
>>> The reclaim_size counter of a space_info object is unsigned. So its value
>>> can never be negative, it's pointless to have an assertion that checks
>>> its value is >= 0, therefore remove it.
>>>
>>> Signed-off-by: Filipe Manana <fdmanana@suse.com>
>>
>> True,
>>
>> Reviewed-by: Nikolay Borisov <nborisov@suse.com> I guess this could be
>> squashed.
>
> Despite being a trivial and small change, I don't think it should be
> squashed into the previous patch, as it's not part of the bug fix
> regarding the counter leak.
> Different changes and unrelated changes should be separate patches.
I meant to say squashed into the original commit that introduced the
assert but it seems it has already been merged into master so yeah, it
will go as it is.
next prev parent reply other threads:[~2020-04-07 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 10:38 [PATCH 2/2] Btrfs: remove pointless assertion on reclaim_size counter fdmanana
2020-04-07 11:32 ` Nikolay Borisov
2020-04-07 14:14 ` Filipe Manana
2020-04-07 15:01 ` Nikolay Borisov [this message]
2020-04-08 17:19 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37df657f-b61d-e1a6-ddb5-72cd421e8cb8@suse.com \
--to=nborisov@suse.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).