linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Can the output of FIEMAP on BTRFS be used to check if a file and its reflink copy might have diverged?
Date: Mon, 22 Sep 2025 13:18:52 -0400	[thread overview]
Message-ID: <38f350b0-9a71-4627-9d36-57bf2f85e67a@gmail.com> (raw)
In-Reply-To: <aNF9xH30pAEq5y4r@infradead.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 1197 bytes --]

On 9/22/25 12:48, Christoph Hellwig wrote:
>> then to uniq, and differences between the outputs for the file and
>> the previous version (a reflink copy) determine what gets backed up.
>>
>> Is this safe under BTRFS, or can it result in data loss due to data
>> not being backed up that should be?  In other words, can it result
>> in data being considered unchanged when it really is?
> This is not safe with any file system.  FIEMAP is purely a debugging
> interface, and the output may or may not correspond to physical
> block numbers.  E.g. for btrfs it points to virtual space, for XFS
> it can point to the RT device.  It also is racy against file I/O.
> 
> The idea of that tool looks nice, but without a proper kernel interface
> to look at the relationship between two files in a way that is locked
> against I/O it is fundamentally unsafe.

Is it safe on XFS if there is no RT device and both files have been
fsync'd and are not modified by userspace?  I believe this is the case
here: reflinks are used to snapshot the files before they are looked at.

I am glad to know that BTRFS is unsafe and will report this.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-09-22 17:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  0:07 Can the output of FIEMAP on BTRFS be used to check if a file and its reflink copy might have diverged? Demi Marie Obenour
2025-09-22  0:50 ` Qu Wenruo
2025-09-22 18:24   ` Demi Marie Obenour
2025-09-22 21:38     ` Qu Wenruo
2025-09-22 16:48 ` Christoph Hellwig
2025-09-22 17:18   ` Demi Marie Obenour [this message]
2025-09-22 17:20     ` Christoph Hellwig
2025-09-22 17:30       ` Demi Marie Obenour
2025-09-22 17:31         ` Christoph Hellwig
2025-09-22 17:54           ` Demi Marie Obenour
2025-09-29  8:50             ` Christoph Hellwig
2025-09-29 23:56               ` Demi Marie Obenour
2025-09-30  1:34               ` Demi Marie Obenour
2025-10-03  7:45                 ` Christoph Hellwig
2025-09-22 23:25       ` Chris Laprise
2025-09-29  8:49         ` Christoph Hellwig
2025-09-29 23:55           ` Demi Marie Obenour
2025-10-03  7:44             ` Christoph Hellwig
2025-10-04  1:09               ` Demi Marie Obenour
2025-10-04  1:43           ` Chris Laprise
2025-10-04  4:51             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38f350b0-9a71-4627-9d36-57bf2f85e67a@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).