From: Nikolay Borisov <nborisov@suse.com>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: backref.c: Use ERR_CAST() to return error code
Date: Mon, 30 Jul 2018 17:16:11 +0300 [thread overview]
Message-ID: <38f87e6c-dd40-7631-0a78-ee9fbe25c3b1@suse.com> (raw)
In-Reply-To: <936a6171-4c1e-2bda-af79-9be9ebe6a8fd@jp.fujitsu.com>
On 26.07.2018 04:22, Misono Tomohiro wrote:
> Use ERR_CAST() instead of void * to make meaning clear.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/backref.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index 7ce0b5f9e99e..9f231bbccb1e 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -2231,7 +2231,7 @@ struct inode_fs_paths *init_ipath(s32 total_bytes, struct btrfs_root *fs_root,
>
> fspath = init_data_container(total_bytes);
> if (IS_ERR(fspath))
> - return (void *)fspath;
> + return ERR_CAST(fspath);
>
> ifp = kmalloc(sizeof(*ifp), GFP_KERNEL);
> if (!ifp) {
>
next prev parent reply other threads:[~2018-07-30 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1532568195.git.misono.tomohiro@jp.fujitsu.com>
2018-07-26 1:22 ` [PATCH] btrfs: backref.c: Use ERR_CAST() to return error code Misono Tomohiro
2018-07-30 14:16 ` Nikolay Borisov [this message]
2018-08-01 12:55 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f87e6c-dd40-7631-0a78-ee9fbe25c3b1@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).