* [PATCH] btrfs: backref.c: Use ERR_CAST() to return error code
[not found] <cover.1532568195.git.misono.tomohiro@jp.fujitsu.com>
@ 2018-07-26 1:22 ` Misono Tomohiro
2018-07-30 14:16 ` Nikolay Borisov
2018-08-01 12:55 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Misono Tomohiro @ 2018-07-26 1:22 UTC (permalink / raw)
To: linux-btrfs
Use ERR_CAST() instead of void * to make meaning clear.
Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
---
fs/btrfs/backref.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 7ce0b5f9e99e..9f231bbccb1e 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -2231,7 +2231,7 @@ struct inode_fs_paths *init_ipath(s32 total_bytes, struct btrfs_root *fs_root,
fspath = init_data_container(total_bytes);
if (IS_ERR(fspath))
- return (void *)fspath;
+ return ERR_CAST(fspath);
ifp = kmalloc(sizeof(*ifp), GFP_KERNEL);
if (!ifp) {
--
2.14.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: backref.c: Use ERR_CAST() to return error code
2018-07-26 1:22 ` [PATCH] btrfs: backref.c: Use ERR_CAST() to return error code Misono Tomohiro
@ 2018-07-30 14:16 ` Nikolay Borisov
2018-08-01 12:55 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Borisov @ 2018-07-30 14:16 UTC (permalink / raw)
To: Misono Tomohiro, linux-btrfs
On 26.07.2018 04:22, Misono Tomohiro wrote:
> Use ERR_CAST() instead of void * to make meaning clear.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/backref.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index 7ce0b5f9e99e..9f231bbccb1e 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -2231,7 +2231,7 @@ struct inode_fs_paths *init_ipath(s32 total_bytes, struct btrfs_root *fs_root,
>
> fspath = init_data_container(total_bytes);
> if (IS_ERR(fspath))
> - return (void *)fspath;
> + return ERR_CAST(fspath);
>
> ifp = kmalloc(sizeof(*ifp), GFP_KERNEL);
> if (!ifp) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: backref.c: Use ERR_CAST() to return error code
2018-07-26 1:22 ` [PATCH] btrfs: backref.c: Use ERR_CAST() to return error code Misono Tomohiro
2018-07-30 14:16 ` Nikolay Borisov
@ 2018-08-01 12:55 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2018-08-01 12:55 UTC (permalink / raw)
To: Misono Tomohiro; +Cc: linux-btrfs
On Thu, Jul 26, 2018 at 10:22:58AM +0900, Misono Tomohiro wrote:
> Use ERR_CAST() instead of void * to make meaning clear.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-01 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1532568195.git.misono.tomohiro@jp.fujitsu.com>
2018-07-26 1:22 ` [PATCH] btrfs: backref.c: Use ERR_CAST() to return error code Misono Tomohiro
2018-07-30 14:16 ` Nikolay Borisov
2018-08-01 12:55 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).