Re: [PATCH v2 1/2] btrfs-progs: warn users about the possible dangers of check --repair

[Nikolay Borisov <nborisov@suse.com>]

On 22.10.19 г. 10:37 ч., Qu Wenruo wrote:
> 
> 
> On 2019/10/22 下午3:33, Johannes Thumshirn wrote:
>> On 21/10/2019 17:22, David Sterba wrote:
>>> --force was added for a different reason, to allow check on a mounted
>>> filesystem. I don't think that combining --repair and --force just to
>>> allow repair is a good idea. There's a 'dangerous repair' mode for eg.
>>> xfs that allows to do live surgery on a mounted filesytem (followed by
>>> immediate reboot). We want to be able to do that eventually.
>>>
>>> I understand where the motivation comes from, let me have a second
>>> thought on that.
>>
>> So how about adding a '--yes' or '--accept', '--dangerous',
>> '--allow-dangeruos' parameter instead of force to skip the warning?
>>
>> My vote would go for '--allow-dangerous'.
> 
> +1 for '--yes', at least e2fsck has a similar '-y' option.

I'\m fine with --yes/-y. It's not just e2fsck but I've seen similar
options in other tools as well.

> 
> Thanks,
> Qu
> 
>>
>> Byte,
>> 	Johannes
>>