From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AEAC433E3 for ; Mon, 24 Aug 2020 18:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 428692074D for ; Mon, 24 Aug 2020 18:28:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="tiTYDHa4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbgHXS2r (ORCPT ); Mon, 24 Aug 2020 14:28:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726803AbgHXS2n (ORCPT ); Mon, 24 Aug 2020 14:28:43 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E5A1C061574 for ; Mon, 24 Aug 2020 11:28:43 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id p4so8379999qkf.0 for ; Mon, 24 Aug 2020 11:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Kbc/0WNSK9GQMv/tCTMpnArWp4pi8OypQ1VFEUDrLJs=; b=tiTYDHa40+e7vInQq3bJ5RrwlxWXhpIhqsp8MSuJn5Jf2jcFRYuF0q5UdYADc+a7+P rqXZmuSHAH3R+6S1PJtqiJt72nTvtTjIFnXLNI4i36TWq5GXGnvVgwJxoFwvAS1bRkLb y8q4Cccqv30W5NejxKIKDDN1WzGAwZrtJqxPHW7Gm3yx1MuDDk0k4Sne0arrWKqQtB9e VvNTmbrmfq9f8Yihv5kTJqD5gzc7yU4PzDyQ5KPfeliMlEyC/AF7vy9aQK3MG9r6zvU6 miVQUqYCmGCD4ZXvye4GIk5VzCRqJ3D2X53QspKVfpFxwWZQ0B0prKSkyyHFN1huEGq6 42EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Kbc/0WNSK9GQMv/tCTMpnArWp4pi8OypQ1VFEUDrLJs=; b=HUubUhardOY+irsYeLCm14OCGKpWcOUTwthjK7qAIhJE2d7CL9ovC+X0ZQg+C8kFeY cBJ9BVyryCkUHuiAPKgLQD5IkX55LCdX0HiFM3kUm/1sb/HN1Pw4aQ05Fe57gEtLnuw7 IVjEdjd0Ti8hgbPYMyeJESnSg5xpgWO97ouAGjrP1anh6fqaaGVKJU+qpnQT4P7ijIiu nAqpARxMhi6sliCU9iR3t8gLlHUjo9FymMprasdK6PoPUIQLytHOPXKG/1R/C8zKWtMu /lbkICN4EtOuFUsHr9q2nOUnYq0zYbHGt2MzFdvEIRCIv1pKJZ0KPNRNDkINGstr+thc Lz6Q== X-Gm-Message-State: AOAM532WG+/ZnBKIqT4O7s63kswJbbMI3HRf3IPDnuQLf7y8VXSBIeYb r/FyDmGUNwHPpXPk9RJSJztj1Q== X-Google-Smtp-Source: ABdhPJz2aev34dwnZ9X3QRxlmhuNgGb0N5/eRXSkAkIaH0ZIeF+Z6EDHjZzU5Y6XtZZRi7frXXBQ/Q== X-Received: by 2002:a05:620a:134b:: with SMTP id c11mr3992176qkl.256.1598293722046; Mon, 24 Aug 2020 11:28:42 -0700 (PDT) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id v185sm7964175qki.26.2020.08.24.11.28.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 11:28:41 -0700 (PDT) Subject: Re: [PATCH v5 2/9] fs: add O_ALLOW_ENCODED open flag To: Omar Sandoval , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Al Viro , Christoph Hellwig Cc: Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com References: From: Josef Bacik Message-ID: <3c44cdf2-e0fd-cea1-4028-d6315ba3b7fd@toxicpanda.com> Date: Mon, 24 Aug 2020 14:28:39 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 8/21/20 3:38 AM, Omar Sandoval wrote: > From: Omar Sandoval > > The upcoming RWF_ENCODED operation introduces some security concerns: > > 1. Compressed writes will pass arbitrary data to decompression > algorithms in the kernel. > 2. Compressed reads can leak truncated/hole punched data. > > Therefore, we need to require privilege for RWF_ENCODED. It's not > possible to do the permissions checks at the time of the read or write > because, e.g., io_uring submits IO from a worker thread. So, add an open > flag which requires CAP_SYS_ADMIN. It can also be set and cleared with > fcntl(). The flag is not cleared in any way on fork or exec; it should > probably be used with O_CLOEXEC in most cases. > > Note that the usual issue that unknown open flags are ignored doesn't > really matter for O_ALLOW_ENCODED; if the kernel doesn't support > O_ALLOW_ENCODED, then it doesn't support RWF_ENCODED, either. It seemed like you agreed to require O_CLOEXEC to be set when using O_ALLOW_ENCODED in your last go around, what happened to that? I know I'd feel better if we had that requirement, and if we aren't I'd like to know why we can't. Thanks, Josef