From: Yan Zheng <yanzheng@21cn.com>
To: Chris Mason <chris.mason@oracle.com>,
Roel Kluin <roel.kluin@gmail.com>,
linux-btrfs@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
yan.zheng@oracle.com
Subject: Re: [PATCH] brtfs: less- and greater than confusion
Date: Mon, 13 Jul 2009 21:43:09 +0800 [thread overview]
Message-ID: <3d0408630907130643s4806d791sddb460c813860437@mail.gmail.com> (raw)
In-Reply-To: <20090713132252.GB4704@think>
2009/7/13 Chris Mason <chris.mason@oracle.com>:
> On Mon, Jul 13, 2009 at 12:30:48AM +0200, Roel Kluin wrote:
>> Without this the loop won't start
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>> ---
>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>> index 3ab80e9..2c873c9 100644
>> --- a/fs/btrfs/volumes.c
>> +++ b/fs/btrfs/volumes.c
>> @@ -2795,7 +2795,7 @@ int btrfs_rmap_block(struct btrfs_mapping_tree=
*map_tree,
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
>> =A0 =A0 =A0 }
>>
>> - =A0 =A0 for (i =3D 0; i > nr; i++) {
>> + =A0 =A0 for (i =3D 0; i < nr; i++) {
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct btrfs_multi_bio *multi;
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct btrfs_bio_stripe *stripe;
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 int ret;
>
> Thanks, this does look buggy. =A0That second loop should just be to v=
erify
> the first loop didn't mess things up. =A0Yan Zheng, is there any reas=
on we
> shouldn't delete it?
>
It's OK to delete it.
Yan Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-07-13 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-12 22:30 [PATCH] brtfs: less- and greater than confusion Roel Kluin
2009-07-13 13:22 ` Chris Mason
2009-07-13 13:26 ` Chris Mason
2009-07-13 13:57 ` Yan Zheng
2009-07-13 13:28 ` David Woodhouse
2009-07-13 13:43 ` Yan Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d0408630907130643s4806d791sddb460c813860437@mail.gmail.com \
--to=yanzheng@21cn.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=roel.kluin@gmail.com \
--cc=yan.zheng@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox