Re: [PATCH] btrfs: introduce rescue=all

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1060 bytes --]



On 2020/9/9 下午3:20, David Sterba wrote:
> On Wed, Sep 09, 2020 at 07:10:49AM +0800, Qu Wenruo wrote:
>>
>>
>> On 2020/9/8 下午11:43, Josef Bacik wrote:
>>> One of the things that came up consistently in talking with Fedora about
>>> switching to btrfs as default is that btrfs is particularly vulnerable
>>> to metadata corruption.  If any of the core global roots are corrupted,
>>> the fs is unmountable and fsck can't usually do anything for you without
>>> some special options.
>>>
>>> What we really want is a simple mount option we can tell all users to
>>> try if things are really wrong that are going to give them the highest
>>> chance of allowing them to mount their file system and copy off their
>>> data in the most direct way possible.
>>
>> Then "all" doesn't look correct for such usage.
>> I'd prefer "salvage" then.
> 
> Let's focus on the functionality for now.
> 
Then the code looks OK to me on the functionality part.

Maybe missing my sob line for the initial fill_dummy_bg() code...

Thanks,
Qu


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]