Re: [PATCH v3 00/19] btrfs: convert to the new mount API

[Anand Jain <anand.jain@oracle.com>]

On 29/11/2023 05:15, David Sterba wrote:
> On Wed, Nov 22, 2023 at 12:17:36PM -0500, Josef Bacik wrote:
>> v2->v3:
>> - Fixed up the various review comments from Dave and Anand.
>> - Added a patch to drop the deprecated mount options we currently have.
> 
> I finished review of v3, there were some changes missing from my v2
> comments, I also did some renames and comment updates. Patches moved
> from topic branch to misc-next, thanks.
Apologies for the delayed review.

The renaming of check_options() should have been in patch 2/19
instead of patch 14/19, avoids confusion in the function stack.

For now, except for the patches listed here [1],
the remaining ones have been reviewed.

   Reviewed-by: Anand Jain <anand.jain@oracle.com>


   fs: indicate request originates from old mount api
   btrfs: split out the mount option validation code into its own helper
   btrfs: set default compress type at btrfs_init_fs_info time
   btrfs: move space cache settings into open_ctree
   btrfs: do not allow free space tree rebuild on extent tree v2
   btrfs: split out ro->rw and rw->ro helpers into their own functions
   btrfs: add a NOSPACECACHE mount option flag
   btrfs: add fs_parameter definitions

[1] {
   btrfs: add parse_param callback for the new mount api
   btrfs: add fs context handling functions
   btrfs: add reconfigure callback for fs_context
   btrfs: add get_tree callback for new mount API
   btrfs: handle the ro->rw transition for mounting different subovls
   btrfs: switch to the new mount API
   }

   btrfs: move the device specific mount options to super.c
   btrfs: remove old mount API code
   btrfs: move one shot mount option clearing to super.c
   btrfs: set clear_cache if we use usebackuproot
   btrfs: remove code for inode_cache and recovery mount options