public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs/024: Remove no longer valid test
Date: Mon, 17 Aug 2020 15:20:05 +0300	[thread overview]
Message-ID: <413e890c-f345-69bf-7b07-fb2c65932c24@suse.com> (raw)
In-Reply-To: <20200817103718.10239-1-nborisov@suse.com>



On 17.08.20 г. 13:37 ч., Nikolay Borisov wrote:
> Kernel commit "btrfs: add missing check for nocow and compression inode
> flags" invalidates the "file compressed, fs mounted with nodatacow"
> mode due to doing more rigorous flags validation, just remove the test.
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

This patch is missing the removal of the respective output from 024.out.
I'll be sending a fixed up version later.

> ---
>  tests/btrfs/024 | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/tests/btrfs/024 b/tests/btrfs/024
> index 0c2ffd7389ab..bcb9048da636 100755
> --- a/tests/btrfs/024
> +++ b/tests/btrfs/024
> @@ -42,13 +42,6 @@ __workout()
>  	$XFS_IO_PROG -f -c "pwrite 0 1M" -c "fsync" $work_file | _filter_xfs_io
>  }
>  
> -echo "*** test nodatacow"
> -_scratch_mkfs > /dev/null 2>&1
> -_scratch_mount "-o nodatacow"
> -__workout
> -_scratch_unmount
> -_check_scratch_fs
> -
>  echo "*** test compress=no"
>  _scratch_mkfs > /dev/null 2>&1
>  _scratch_mount "-o compress=no"
> 

  parent reply	other threads:[~2020-08-17 12:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 10:37 [PATCH 1/3] btrfs/024: Remove no longer valid test Nikolay Borisov
2020-08-17 10:37 ` [PATCH 2/3] btrfs/173: Adjust compress file check Nikolay Borisov
2020-08-17 10:47   ` Anand Jain
2020-08-17 10:37 ` [PATCH 3/3] btrfs/174: Adjust error message when setting compressed flag Nikolay Borisov
2020-08-17 10:49   ` Anand Jain
2020-08-17 14:24   ` Marcos Paulo de Souza
2020-08-17 12:20 ` Nikolay Borisov [this message]
2020-08-17 13:40 ` [PATCH v2] btrfs/024: Remove no longer valid test Nikolay Borisov
2020-08-17 14:17   ` Marcos Paulo de Souza
2020-08-30 16:08   ` Eryu Guan
2020-08-30 19:30     ` Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=413e890c-f345-69bf-7b07-fb2c65932c24@suse.com \
    --to=nborisov@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox