From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lithops.sigma-star.at (mailout.nod.at [116.203.167.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AB6837474A; Thu, 26 Feb 2026 21:45:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.167.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772142332; cv=none; b=IFd52GvpHOAdGpveFehKLmbbO5fvUrqcmqpDuRfy7+8fZ/f0YJ4EApFZZKmZxtKHT/YBePDsEOCJr7NDvVh4rs5OuwR1DGRKASsda5GEvRqyN31o09LGGb1RmmR7pbXS7DMXMg6kt+UEOWwDAMxkSPIkhUS6WbdNCLNJXHws/t0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772142332; c=relaxed/simple; bh=wDuHIlgTWxVQ39bsZXRk3dTlopMj1ECzJP7BUeFMfZ8=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=lDY3FKa1jJ6BRnI7iLo7H6BEm9ZA+hwvbRmi8+3d4Yhd94c/0pR9L39K0ABqotCXGeavjaCYSuDeJyCc1xlsJ0Vu3v1vTG47pg8YAYV0Nz0GLoiCPfIMAMa81UJPXyyiZuxm8jSMjKtp2EzJD3d2iZbkUHHGyULDxitiqgF8vYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at; spf=fail smtp.mailfrom=nod.at; arc=none smtp.client-ip=116.203.167.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nod.at Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 0B325298599; Thu, 26 Feb 2026 22:45:29 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vJnDbvqv8fxU; Thu, 26 Feb 2026 22:45:28 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id E98F629859D; Thu, 26 Feb 2026 22:45:27 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jjhkwk3e1cfi; Thu, 26 Feb 2026 22:45:27 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 2545C298580; Thu, 26 Feb 2026 22:45:27 +0100 (CET) Date: Thu, 26 Feb 2026 22:45:26 +0100 (CET) From: Richard Weinberger To: hch Cc: Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , will , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , davem , Andreas Larsson , anton ivanov , Johannes Berg , Thomas Gleixner , mingo , bp , dave hansen , x86 , hpa , Herbert Xu , dan j williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha , linux-kernel , linux-arm-kernel , loongarch , linuxppc-dev , linux-riscv , linux-s390 , sparclinux , linux-um , Linux Crypto Mailing List , linux-btrfs , linux-arch , linux-raid Message-ID: <445921547.2198.1772142326749.JavaMail.zimbra@nod.at> In-Reply-To: <20260226151106.144735-4-hch@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-4-hch@lst.de> Subject: Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF147 (Linux)/8.8.12_GA_3809) Thread-Topic: um/xor: don't override XOR_SELECT_TEMPLATE Thread-Index: geHUNAwCPFDc7iDnvkYlaCznwUsWXw== ----- Urspr=C3=BCngliche Mail ----- > Von: "hch" > XOR_SELECT_TEMPLATE is only ever called with a NULL argument, so all the > ifdef'ery doesn't do anything. With our without this, the time travel > mode should work fine on CPUs that support AVX2, as the AVX2 > implementation is forced in this case, and won't work otherwise. IIRC Johannes added XOR_SELECT_TEMPLATE() here to skip the template selection logic because it didn't work with time travel mode. Johannes, can you please test whether this change does not break time travel mode? Thanks, //richard