From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Filipe Manana <fdmanana@kernel.org>, Johannes Thumshirn <jth@kernel.org>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Filipe Manana <fdmanana@suse.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:BTRFS FILE SYSTEM" <linux-btrfs@vger.kernel.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH v3] btrfs: tests: add selftests for RAID stripe-tree
Date: Wed, 2 Oct 2024 14:48:14 +0000 [thread overview]
Message-ID: <459f05cd-23fd-405c-b52a-bd2b667eba62@wdc.com> (raw)
In-Reply-To: <CAL3q7H5mRqf9hP-boXj7Tgd6SLYsUEyAboHzB7ZEw4vsgHLX8g@mail.gmail.com>
On 02.10.24 16:24, Filipe Manana wrote:
>> + for (int i = 0; i < RST_TEST_NUM_DEVICES; i++) {
>> + struct btrfs_device *dev;
>> +
>> + dev = btrfs_alloc_dummy_device(fs_info);
> Still missing the error check, it can fail with ERR_PTR(-ENOMEM).
>
> With that fixed:
>
> Reviewed-by: Filipe Manana<fdmanana@suse.com>
Oops, fixed.
prev parent reply other threads:[~2024-10-02 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 10:11 [PATCH v3] btrfs: tests: add selftests for RAID stripe-tree Johannes Thumshirn
2024-10-02 14:24 ` Filipe Manana
2024-10-02 14:48 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459f05cd-23fd-405c-b52a-bd2b667eba62@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=josef@toxicpanda.com \
--cc=jth@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox