Re: [PATCH] common/btrfs: exercise all algorithms in _btrfs_stress_defrag()

[Qu Wenruo <wqu@suse.com>]

在 2026/9/16 00:59, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> _btrfs_stress_defrag() is testing only zlib and lzo compression with the
> defrag tool, but we also have zstd support for some years now.
> 
> Change _btrfs_stress_defrag() to iterate over the list of all supported
> compression algorithms given by _btrfs_compression_algos().
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   common/btrfs | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/common/btrfs b/common/btrfs
> index 3eb68beb..1854cf07 100644
> --- a/common/btrfs
> +++ b/common/btrfs
> @@ -414,16 +414,17 @@ _btrfs_stress_defrag()
>   {
>   	local btrfs_mnt=$1
>   	local compress=$2
> +	local algo_list=($(_btrfs_compression_algos))
>   
>   	while true; do
>   		if [ "$compress" == "nocompress" ]; then
>   			find $btrfs_mnt \( -type f -o -type d \) -exec \
>   			$BTRFS_UTIL_PROG filesystem defrag {} \;
>   		else
> -			find $btrfs_mnt \( -type f -o -type d \) -exec \
> -			$BTRFS_UTIL_PROG filesystem defrag -clzo {} \;
> -			find $btrfs_mnt \( -type f -o -type d \) -exec \
> -			$BTRFS_UTIL_PROG filesystem defrag -czlib {} \;
> +			for algo in ${algo_list[@]}; do
> +				find $btrfs_mnt \( -type f -o -type d \) -exec \
> +				     $BTRFS_UTIL_PROG filesystem defrag -c$algo {} \;
> +			done
>   		fi
>   	done
>   }