From: Ed Tomlinson <edt@aei.ca>
To: Filipe Manana <fdmanana@gmail.com>
Cc: Robin Ruede <r.ruede@gmail.com>, <linux-btrfs@vger.kernel.org>,
Robin Ruede <rruede+git@gmail.com>
Subject: Re: [PATCH] btrfs: fix resending received snapshot with parent
Date: Mon, 12 Oct 2015 20:31:33 -0400 [thread overview]
Message-ID: <466cad37-fdc5-42d7-ad6c-69f93d55208a@aei.ca> (raw)
In-Reply-To: <CAL3q7H7AYV_BEkT+_gg5qYK1Yvk=dMo9Xoi5cnZx97g=w7qKpQ@mail.gmail.com>
On Friday, October 9, 2015 4:24:10 PM EDT, Filipe Manana wrote:
> On Wed, Sep 30, 2015 at 8:23 PM, Robin Ruede <r.ruede@gmail.com> wrote:
>> This fixes a regression introduced by 37b8d27d between v4.1 and v4.2.
>>
>> When a snapshot is received, its received_uuid is set to the original
>> uuid of the subvolume. When that snapshot is then resent to a third
>> filesystem, it's received_uuid is set to the second uuid
>> instead of the original one. The same was true for the parent_uuid. ...
> Reviewed-by: Filipe Manana <fdmanana@suse.com>
>
> Thanks for fixing this.
> I've added this to my integration branch [1] and will send soon a pull
> request to Chris for 4.4, including this fix plus a few others for
> send/receive, after some more testing.
>
> I've also made an xfstest for it [1, 2]
Another thanks for this fix. It fixes things here. I am runing 4.2.3 with
the 4.3 btrfs tree pulled on top of it along with this fix. Incremental
sends
are now working again.
Tested-by: Ed Tomlinson <edt@aei.ca>
This fixes a regression, can we please get into 4.3?
Thanks
Ed Tomlinson
next prev parent reply other threads:[~2015-10-13 0:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 19:23 [PATCH] btrfs: fix resending received snapshot with parent Robin Ruede
2015-10-09 20:24 ` Filipe Manana
2015-10-13 0:31 ` Ed Tomlinson [this message]
2015-10-13 19:07 ` Filipe Manana
2022-01-02 5:58 ` Dāvis Mosāns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466cad37-fdc5-42d7-ad6c-69f93d55208a@aei.ca \
--to=edt@aei.ca \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=r.ruede@gmail.com \
--cc=rruede+git@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).