Re: [PATCH v2] btrfs-progs: add --subvol option to mkfs.btrfs

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2024/7/31 06:34, Qu Wenruo 写道:
>
>
> 在 2024/7/30 23:20, Mark Harmstone 写道:
>> Thanks Qu.
>>
>> On 30/7/24 10:55, Qu Wenruo wrote:
>>> And before the --subvolume option, I'm more intesrested in getting rid
>>> of the function completely.
>>
>> With respect, I'd appreciate it if you waited for a version of this
>> patch to be upstreamed before doing any refactoring.
>
> But I really do not like the way new subvolumes are created.
>
> If we merge it for now, it will take way more time to change/fix it.
> I do not think that's how we do the development.

Just to be more clear, I'm not against all your awesome work on bringing
the new feature to mkfs.

It's the fact that we're making the --rootdir feature more and more like
a subset of FUSE btrfs implementation.

In that case, there is too much historic burden left to the code base,
and I believe it's the time to clean them up, other than building more
and more things on an unstable base and hoping new comers will clean
them up.


So please really consider making the existing code better, before
pushing a new feature for --rootdir option.

And the inode size calculating part is definitely not a proper thing
that would appear in a FUSE/kernel fs implementation, even it works fine
for now.

Thanks,
Qu

>
> Thanks,
> Qu
>
>>
>> Thanks
>>
>> Mark
>>
>