From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Sidong Yang <realwakka@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: qgroup: remove outdated comment
Date: Tue, 23 Mar 2021 06:57:15 +0800 [thread overview]
Message-ID: <4736ee1f-2749-87df-e357-ff785b511087@gmx.com> (raw)
In-Reply-To: <20210322140316.384012-1-realwakka@gmail.com>
On 2021/3/22 下午10:03, Sidong Yang wrote:
> This comment is outdated and this patch remove
> it to avoid confusion.
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> cmds/qgroup.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/cmds/qgroup.c b/cmds/qgroup.c
> index 2da83ffd..b33f77fa 100644
> --- a/cmds/qgroup.c
> +++ b/cmds/qgroup.c
> @@ -81,9 +81,6 @@ static int _cmd_qgroup_assign(const struct cmd_struct *cmd, int assign,
>
> path = argv[optind + 2];
>
> - /*
> - * FIXME src should accept subvol path
> - */
> if (btrfs_qgroup_level(args.src) >= btrfs_qgroup_level(args.dst)) {
> error("bad relation requested: %s", path);
> return 1;
>
next prev parent reply other threads:[~2021-03-22 22:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 14:03 [PATCH] btrfs-progs: qgroup: remove outdated comment Sidong Yang
2021-03-22 22:57 ` Qu Wenruo [this message]
2021-03-23 14:48 ` David Sterba
2021-03-23 15:43 ` Sidong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4736ee1f-2749-87df-e357-ff785b511087@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox