Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Zach Brown <zach.brown@oracle.com>
To: Avi Kivity <avi@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: packing structures and numbers
Date: Fri, 03 Oct 2008 11:37:13 -0700	[thread overview]
Message-ID: <48E66659.1030202@oracle.com> (raw)
In-Reply-To: <48E6053A.8010100@redhat.com>

Avi Kivity wrote:
> I've been reading btrfs's on-disk format, and two things caught my eye
> 
> - attribute((packed)) structures everywhere, often with misaligned
> fields.  This conserves space, but can be harmful to in-memory
> performance on some archs.

How harmful?  Do you have any profiles that can even pick this out of
the noise?

- z

  parent reply	other threads:[~2008-10-03 18:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 11:42 packing structures and numbers Avi Kivity
2008-10-03 12:22 ` Chris Mason
2008-10-03 13:40   ` Avi Kivity
2008-10-04  0:22   ` Daniel Phillips
2008-10-04  0:28     ` Chris Mason
2008-10-04  0:35       ` Daniel Phillips
2008-10-04  0:43       ` Daniel Phillips
2008-10-04  8:27         ` Avi Kivity
2008-10-03 18:37 ` Zach Brown [this message]
2008-10-04  8:31   ` Avi Kivity
2008-10-04 16:34     ` Andi Kleen
2008-10-05  5:31       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E66659.1030202@oracle.com \
    --to=zach.brown@oracle.com \
    --cc=avi@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox