From: Avi Kivity <avi@redhat.com>
To: yanhai zhu <zhu.yanhai@gmail.com>
Cc: Tarkan Erimer <tarkan.erimer@turknet.net.tr>,
linux-btrfs@vger.kernel.org
Subject: Re: Compile error of latest hotfix release of btrfs
Date: Mon, 03 Nov 2008 22:22:51 +0200 [thread overview]
Message-ID: <490F5D9B.5040400@redhat.com> (raw)
In-Reply-To: <977a2be20811030719q674bc5bo1f6ce200806e583@mail.gmail.com>
yanhai zhu wrote:
> sorry,
>
> --
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 9b37ce6..04a0e58 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -2539,7 +2539,11 @@ int extent_readpages(struct extent_io_tree *tree,
> /* open coding of lru_cache_add, also not exported */
> page_cache_get(page);
> if (!pagevec_add(&pvec, page))
> + #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)
> + __pagevec_lru_add_file(&pvec);
> + #else
> __pagevec_lru_add(&pvec);
> + #endif
>
Suggest sticking in some compat header:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,28)
+# define __pagevec_lru_add_file __pagevec_lru_add
+#endif
To reduce impact on code that is intended to go to mainline.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2008-11-03 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 8:17 Compile error of latest hotfix release of btrfs Tarkan Erimer
2008-11-03 13:49 ` yanhai zhu
2008-11-03 14:36 ` Tarkan Erimer
2008-11-03 15:19 ` yanhai zhu
2008-11-03 20:22 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490F5D9B.5040400@redhat.com \
--to=avi@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=tarkan.erimer@turknet.net.tr \
--cc=zhu.yanhai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox