Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning

Andi Kleen
2009-01-09T06:57:08Z

On Thu, Jan 08, 2009 at 07:42:48PM -0800, Linus Torvalds wrote:
> > I actually often use noinline when developing code simply because it
> > makes it easier to read oopses when gcc doesn't inline ever static
> > (which it normally does if it only has a single caller)
>
> Yes. Gcc inlining is a total piece of sh*t.

The static inlining by default (unfortunately) saves a lot of text size.

For testing I built an x86-64 allyesconfig kernel with
-fno-inline-functions-called-once (which disables the default static
inlining), and it increased text size by ~4.1% (over 2MB for a allyesconfig
kernel). So I think we have to keep that, dropping it would cost too
much :/

-Andi

--
ak@linux.intel.com