linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: Anand Jain <anand.jain@oracle.com>,
	dsterba@suse.com, gpiccoli@igalia.com
Subject: [PATCH 3/4] btrfs: disable the device add feature for temp-fsid
Date: Wed,  4 Oct 2023 23:00:26 +0800	[thread overview]
Message-ID: <496f6f7ad93236768f7df67d8ebd98a0fff6812c.1696431315.git.anand.jain@oracle.com> (raw)
In-Reply-To: <cover.1696431315.git.anand.jain@oracle.com>

The device addition operation will transform the cloned temp-fsid mounted
device into a multi-device filesystem. Therefore, it is marked as
unsupported.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 fs/btrfs/ioctl.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 848b7e6f6421..7d8d217cf5fd 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2635,6 +2635,12 @@ static long btrfs_ioctl_add_dev(struct btrfs_fs_info *fs_info, void __user *arg)
 		return -EINVAL;
 	}
 
+	if (fs_info->fs_devices->temp_fsid) {
+		btrfs_err(fs_info,
+			  "device add not supported on cloned temp-fsid mount");
+		return -EINVAL;
+	}
+
 	if (!btrfs_exclop_start(fs_info, BTRFS_EXCLOP_DEV_ADD)) {
 		if (!btrfs_exclop_start_try_lock(fs_info, BTRFS_EXCLOP_DEV_ADD))
 			return BTRFS_ERROR_DEV_EXCL_RUN_IN_PROGRESS;
-- 
2.38.1


  parent reply	other threads:[~2023-10-04 15:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 15:00 [PATCH 0/4] btrfs: sysfs and unsupported temp-fsid features for clones Anand Jain
2023-10-04 15:00 ` [PATCH 1/4] btrfs: comment for temp-fsid, fsid, and metadata_uuid Anand Jain
2023-10-04 15:00 ` [PATCH 2/4] btrfs: disable seed feature for temp-fsid Anand Jain
2023-10-04 15:00 ` Anand Jain [this message]
2023-10-04 15:00 ` [PATCH 4/4] btrfs: show temp_fsid feature in sysfs Anand Jain
2023-10-06 14:55   ` David Sterba
2023-10-07  9:12     ` Anand Jain
2023-10-07  9:31       ` Anand Jain
2023-10-06 15:07 ` [PATCH 0/4] btrfs: sysfs and unsupported temp-fsid features for clones David Sterba
2023-10-07 10:30   ` Anand Jain
2023-10-09  7:00     ` Guilherme G. Piccoli
2023-10-09  8:07       ` Anand Jain
2023-10-09 23:59         ` David Sterba
2023-10-10  1:22           ` Anand Jain
2023-10-18 13:37           ` Guilherme G. Piccoli
2023-10-18 23:04             ` David Sterba
2023-10-19  8:06               ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496f6f7ad93236768f7df67d8ebd98a0fff6812c.1696431315.git.anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=gpiccoli@igalia.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).