From: jim owens <jowens@hp.com>
To: Lee Trager <lt73@cs.drexel.edu>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: experimental branch rebased
Date: Tue, 03 Mar 2009 17:07:22 -0500 [thread overview]
Message-ID: <49ADAA1A.6050709@hp.com> (raw)
In-Reply-To: <20090226190527.GA13057@tux64-01>
Lee,
The 02/26/2009 version is missing some of the patches that
were in the 02/20/2009 version so it will not compile on 26.
I found the bug in the patch that breaks on 26:
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)
if (!trylock_page(page))
+#else
+ if(!TestSetPageLocked(page))
+#endif
It should be
if (TestSetPageLocked(page))
because pass/fail is reversed on those functions.
While I was testing, I ported back to 24 on
ubuntu and made it work with 2.6.24-23-generic
with the experimental tree from feb 25.
I will give you the 24 patches to include in your
patch as soon as you have a version that I can
rebase against the current experimental on 24/26.
jim
next prev parent reply other threads:[~2009-03-03 22:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 15:45 experimental branch rebased Chris Mason
2009-02-26 19:05 ` Lee Trager
2009-03-03 22:07 ` jim owens [this message]
2009-03-07 4:53 ` Lee Trager
2009-03-09 13:26 ` jim owens
2009-02-26 22:54 ` Steven Pratt
2009-02-27 16:25 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ADAA1A.6050709@hp.com \
--to=jowens@hp.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lt73@cs.drexel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox