From: Jeff Mahoney <jeffm@suse.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Btrfs Development List <linux-btrfs@vger.kernel.org>
Subject: Re: PATCH] btrfs: Check transaction start
Date: Mon, 30 Mar 2009 13:44:23 -0400 [thread overview]
Message-ID: <49D104F7.9040007@suse.com> (raw)
In-Reply-To: <873acunc4f.fsf@basil.nowhere.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andi Kleen wrote:
> Jeff Mahoney <jeffm@suse.com> writes:
>> wake_up_process(root->fs_info->cleaner_kthread);
>> @@ -2197,10 +2199,12 @@ int btrfs_commit_super(struct btrfs_root
>> btrfs_clean_old_snapshots(root);
>> mutex_unlock(&root->fs_info->cleaner_mutex);
>> trans = btrfs_start_transaction(root, 1);
>> + BUG_ON(IS_ERR(trans));
>
> Would it make sense to use a different macro for things that
> are expected to be fixed later? BUG_ON_I_SUCK() or TMP_BUG_ON() or
> something like that?
> I think that would make it clearer that things are only temporary.
> At least it should be documented somewhere.
Yeah, that's a good idea. I'll update the patch set.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iEYEARECAAYFAknRBPYACgkQLPWxlyuTD7LYiACdE/x30BaKpCvWEXwXYfnRBgMl
EZ0An2VDeUGM12PXFcKgUxzNSbScQ3hA
=yzWl
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2009-03-30 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 3:09 PATCH] btrfs: Check transaction start Jeff Mahoney
2009-03-30 17:39 ` Andi Kleen
2009-03-30 17:44 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D104F7.9040007@suse.com \
--to=jeffm@suse.com \
--cc=andi@firstfloor.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox