Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>,
	john terragon <jterragon@gmail.com>
Cc: sys <system@lechevalier.se>, Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: hierarchical, tree-like structure of snapshots
Date: Fri, 1 Jan 2021 14:42:04 +0300	[thread overview]
Message-ID: <49e405a1-ca48-7654-6b1e-408bcf6553b8@gmail.com> (raw)
In-Reply-To: <20201231213650.GT31381@hungrycats.org>


[-- Attachment #1.1: Type: text/plain, Size: 1841 bytes --]

01.01.2021 00:36, Zygo Blaxell пишет:
...
> 
> Yeah, I only checked that send completed without error and produced a
> smaller stream.
> 
> I just dumped the send metadata stream from the incremental snapshot now,
> and it's more or less garbage at the start:
> 
> 	# btrfs sub create A
> 	# btrfs sub create B
> 	# date > A/date
> 	# date > B/date
> 	# mkdir A/t B/u
> 	# btrfs sub snap -r A A_RO
> 	# btrfs sub snap -r B B_RO
...
> 	# btrfs send A_RO | btrfs receive -v /tmp/test
> 	At subvol A_RO
> 	At subvol A_RO
> 	receiving subvol A_RO uuid=995adde4-00ac-5e49-8c6f-f01743def072, stransid=7329268
> 	write date - offset=0 length=29
> 	BTRFS_IOC_SET_RECEIVED_SUBVOL uuid=995adde4-00ac-5e49-8c6f-f01743def072, stransid=7329268
> 	# btrfs send B_RO -p A_RO | btrfs receive -v /tmp/test
> 	At subvol B_RO
> 	At snapshot B_RO
> 	receiving snapshot B_RO uuid=4aa7db26-b219-694e-9b3c-f8f737a46bdb, ctransid=7329268 parent_uuid=995adde4-00ac-5e49-8c6f-f01743def072, parent_ctransid=7329268
> 	ERROR: link date -> date failed: File exists
> 
> The btrfs_compare_trees function can handle arbitrary tree differences,

I am not sure. It apparently relies on the fact that inodes are ever
monotonically increasing. This is probably true for clones of the same
subvolume (I assume clone inherits highest_objectid) but two subvolumes
created independently have the same range of inode numbers.

Also I am not sure if using later clone as base for difference to
earlier clone will work for the same reason.

> but something happens in one of the support functions and we get a
> bogus link command.  The rest of the stream is OK though:  we fill
> in the contents of B_RO/date, rename A_RO/t to B_RO/u, and update all
> the timestamps.
> 
> Oh well, I didn't say send didn't have any bugs.  ;)
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  parent reply	other threads:[~2021-01-01 11:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30 16:56 hierarchical, tree-like structure of snapshots john terragon
2020-12-30 17:03 ` john terragon
2020-12-30 17:24 ` sys
2020-12-30 17:39   ` john terragon
2020-12-31  7:05     ` Andrei Borzenkov
2020-12-31 10:00       ` Forza
2020-12-31 16:08       ` john terragon
2020-12-31 17:28         ` Zygo Blaxell
2020-12-31 18:19           ` john terragon
2020-12-31 19:42             ` Andrei Borzenkov
2020-12-31 20:48               ` john terragon
2020-12-31 21:36                 ` Zygo Blaxell
2021-01-01  4:54                   ` john terragon
2021-01-01 11:42                   ` Andrei Borzenkov [this message]
2021-01-01 20:40                     ` Andrei Borzenkov
2021-01-01 23:11                       ` Zygo Blaxell
2021-01-02  9:25                         ` Andrei Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49e405a1-ca48-7654-6b1e-408bcf6553b8@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=ce3g8jdj@umail.furryterror.org \
    --cc=jterragon@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=system@lechevalier.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox