From: Johannes Thumshirn <jthumshirn@suse.de>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 1/6] btrfs: Refactor cow_file_range_async
Date: Thu, 21 Feb 2019 16:07:10 +0100 [thread overview]
Message-ID: <49f1484a-e4c3-70cf-c443-708e916c4f90@suse.de> (raw)
In-Reply-To: <ca7d67fb-8f64-d6c5-97f1-cff2de91f411@suse.com>
On 21/02/2019 14:25, Nikolay Borisov wrote:
>
>
> On 21.02.19 г. 15:15 ч., Johannes Thumshirn wrote:
>> On 21/02/2019 12:57, Nikolay Borisov wrote:
>>>
>>> static int cow_file_range_async(struct inode *inode, struct page *locked_page,
>>> @@ -1190,45 +1201,68 @@ static int cow_file_range_async(struct inode *inode, struct page *locked_page,
>>> unsigned int write_flags)
>>> {
>>> struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
>>> - struct async_cow *async_cow;
>>> + struct async_cow *ctx;
>>> + struct async_chunk *async_cow;
>>
>> In case you have to re-send the patch you could maybe rename the
>> async_cow variable to async_chunk or sth like that. Would make the
>> resulting code a little bit clearer but no strong opinions here.
>
> The reason I left it like that is to minimize the resulting diff.
Understood, but now we have a 'ctx' of type 'struct async_cow' and a
'*async_cow' of type 'struct asyn_chunk'. This is the type of code that
will make people go WTF when they read it in 3-4 cycles.
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-02-21 15:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 11:57 [PATCH v3 0/6] Compress path cleanups Nikolay Borisov
2019-02-21 11:57 ` [PATCH v3 1/6] btrfs: Refactor cow_file_range_async Nikolay Borisov
2019-02-21 13:15 ` Johannes Thumshirn
2019-02-21 13:25 ` Nikolay Borisov
2019-02-21 15:07 ` Johannes Thumshirn [this message]
2019-02-21 15:09 ` Nikolay Borisov
2019-02-22 18:05 ` David Sterba
2019-02-22 18:13 ` David Sterba
2019-02-21 11:57 ` [PATCH v3 2/6] btrfs: Remove fs_info from struct async_chunk Nikolay Borisov
2019-02-21 13:07 ` Johannes Thumshirn
2019-02-21 11:57 ` [PATCH v3 3/6] btrfs: Make compress_file_range take only " Nikolay Borisov
2019-02-21 13:07 ` Johannes Thumshirn
2019-02-21 11:57 ` [PATCH v3 4/6] btrfs: Replace clear_extent_bit with unlock_extent Nikolay Borisov
2019-02-21 11:57 ` [PATCH v3 5/6] btrfs: Set iotree only once in submit_compressed_extents Nikolay Borisov
2019-02-21 11:57 ` [PATCH v3 6/6] btrfs: Factor out common extent locking code " Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49f1484a-e4c3-70cf-c443-708e916c4f90@suse.de \
--to=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).