public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Ric Wheeler <rwheeler@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>,
	chris.mason@oracle.com, linux-btrfs@vger.kernel.org,
	neilb@suse.de, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/4] md: Factor out RAID6 algorithms into lib/
Date: Sat, 18 Jul 2009 08:45:13 -0400	[thread overview]
Message-ID: <4A61C3D9.6020200@zytor.com> (raw)
In-Reply-To: <1247918016.22313.138.camel@macbook.infradead.org>

David Woodhouse wrote:
>=20
> I'm only interested in what we can use directly within btrfs -- and
> ideally I do want something which gives me an _arbitrary_ number of
> redundant blocks, rather than limiting me to 2. But the legacy code i=
s
> good enough for now=C2=B9.
>=20
> When I get round to wanting more, I was thinking of lifting something
> like http://git.infradead.org/mtd-utils.git?a=3Dblob;f=3Dfec.c to sta=
rt
> with, and maybe hoping that someone cleverer will come up with someth=
ing
> better.
>=20
> The less I have to deal with Galois Fields, the happier I'll be.
>=20

Well, if you want something with more than 2-block redundancy you need=20
something other than the existing RAID-6 code which, as you know, is a=20
special case of general Reed-Solomon coding that I happen to have spent=
=20
a lot of time optimizing.  The FEC code is not optimized at all if I ca=
n=20
tell, and certainly doesn't use SSE in any way -- never mind the GF=20
accelerators that are starting to appear.  That doesn't mean it=20
*couldn't*, just that noone has done the work to either implement it or=
=20
prove it can't be done.

Either way, perhaps the Plank paper that Rik pointed to could be useful=
=20
as a starting point; it's probably worth taking their performance=20
numbers with a *major* grain of salt: their implementation of RAID-6=20
"RS-Opt" which is supposed to be equivalent to my code performs at
400 MB/s, which is less than Pentium III-era performance of the real=20
world code (they compare not to real code but to their own=20
implementation in Java, called "Jerasure".)  Implementability using rea=
l=20
array instruction sets is key to decent performance.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-07-18 12:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13 14:11 [PATCH 1/4] md: Factor out RAID6 algorithms into lib/ David Woodhouse
2009-07-15 19:23 ` Dan Williams
2009-07-15 20:16   ` Chris Mason
2009-07-15 22:11     ` Dan Williams
2009-07-16 17:38   ` H. Peter Anvin
2009-07-17 14:22     ` Ric Wheeler
2009-07-17 15:20       ` H. Peter Anvin
2009-07-17 15:35         ` Ric Wheeler
2009-07-17 15:40           ` H. Peter Anvin
2009-07-17 15:47             ` Ric Wheeler
2009-07-17 15:49               ` H. Peter Anvin
2009-07-17 15:58                 ` Ric Wheeler
2009-07-17 18:59                   ` Alex Elsayed
2009-07-17 19:02                     ` Alex Elsayed
2009-07-29 18:16                       ` H. Peter Anvin
2009-07-17 19:12                 ` Gregory Maxwell
2009-07-18 11:53                 ` David Woodhouse
2009-07-18 12:45                   ` H. Peter Anvin [this message]
2009-07-18 18:50                     ` Alex Elsayed
2009-07-18 18:52                       ` Alex Elsayed
2009-07-29 18:20                         ` H. Peter Anvin
2009-07-18 12:49                   ` Ric Wheeler
2009-07-18 16:26                   ` Dan Williams
2009-07-18 18:42                     ` David Woodhouse
2009-07-18 20:04                       ` Dan Williams
2009-07-19 18:04                         ` David Woodhouse
2009-07-20  5:21                           ` H. Peter Anvin
2009-07-17 15:51               ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A61C3D9.6020200@zytor.com \
    --to=hpa@zytor.com \
    --cc=chris.mason@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=rwheeler@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox