public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Zach Brown <zach.brown@oracle.com>
To: Chris Mason <chris.mason@oracle.com>,
	Sage Weil <sage@newdream.net>,
	linux-btrfs@vger.kernel.org, hch@lst.de
Subject: Re: [RFC] big fat transaction ioctl
Date: Wed, 11 Nov 2009 10:22:22 -0800	[thread overview]
Message-ID: <4AFB00DE.9070101@oracle.com> (raw)
In-Reply-To: <20091111145435.GB5566@think>


> I like this much more than providing a journal start/stop to userland.
> If we can get Christoph to ack the exports we can work on the interface
> in general.

I'll note, briefly, that it seems dangerous to call right into the sys_
functions instead of going through the architecture's syscall number
dispatching path.  Do you know if the syscalls you're calling have
compat wrappers on some architectures for some userspace abis?

With that out of the way, though, I'll get on to my bigger point.

This interface for specifying an array of syscalls to call looks a whole
lot like the work that fs/aio.c, syslets, and acall have all done.  The
flags for stopping processing of the array based on errors from the
syscalls are remarkably similar to Ingo's atom structs.

So maybe there's an opportunity for a generic syscall for processing
batches of syscalls.  Maybe you'll bracket some of them with btrfs
ioctls for flagging the task_struct as being in a btrfs transaction, but
maybe you'll also flag some for concurrent acall processing or nutty
syslet thread spawning if they block.

It'll probably take some work to be able to call syscall handlers from C
on all architectures, and we'd have to be really careful about the
semantics if we start mixing btrfs ioctls and async flags, but it just
might be worth it.

- z

  reply	other threads:[~2009-11-11 18:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 20:12 [RFC] big fat transaction ioctl Sage Weil
2009-11-10 20:44 ` Andrey Kuzmin
2009-11-10 22:13   ` Sage Weil
2009-11-11  0:49     ` Jeremy Fitzhardinge
2009-11-11  5:15       ` Sage Weil
2009-11-11 15:03     ` Chris Mason
2009-11-11 15:41       ` Andrey Kuzmin
2009-11-11 15:55         ` Chris Mason
2009-11-11 17:19       ` Sage Weil
2009-11-12  3:56         ` Andrey Kuzmin
2009-11-11 14:54 ` Chris Mason
2009-11-11 18:22   ` Zach Brown [this message]
2009-11-11 22:22     ` Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFB00DE.9070101@oracle.com \
    --to=zach.brown@oracle.com \
    --cc=chris.mason@oracle.com \
    --cc=hch@lst.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sage@newdream.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox