public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@myrealbox.com>
To: TARUISI Hiroaki <taruishi.hiroak@jp.fujitsu.com>
Cc: luto@mit.edu, kreijack@libero.it, linux-btrfs@vger.kernel.org,
	chris.mason@oracle.com
Subject: Re: BUG: Link from sub volume, then remove the subvolume -> wrong link
Date: Mon, 14 Dec 2009 23:04:14 -0500	[thread overview]
Message-ID: <4B270ABE.5090109@myrealbox.com> (raw)
In-Reply-To: <4B26D504.3080201@jp.fujitsu.com>

TARUISI Hiroaki wrote:
> Hi,
> 
> I think message:'Operation not permitted' is more
> proper for this problem than 'Invalid cross-device
> link' simply because this link is not cross-device
> link.
> 
> Of course, this operation is prohibited not by security
> policy but by inner limitation of btrfs, this usage of
> EPERM may be a kind of abuses...
> 

EOPNOTSUPP?  EINVAL?

Seriously, though, something should go in.  Chris, any opinion?

--Andy

> Regards,
> taruisi
> 
> (2009/12/15 3:43), Andrew Lutomirski wrote:
>> [cc: Chris -- This, or something like it, should probably go to
>> stable, but it needs to make it to upstream somewhere first.]
>>
>> On Sun, Dec 13, 2009 at 6:42 PM, TARUISI Hiroaki
>> <taruishi.hiroak@jp.fujitsu.com> wrote:
>>> Hi,
>>>
>>> We can see the patch in ML archive or at 'Patchwork' site.
>>>
>>>  http://patchwork.kernel.org/patch/59519/
>> That fixes the bug, but shouldn't the error be EXDEV?  It has nothing
>> to do with permissions.
>>
>> --Andy
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2009-12-15  4:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 19:54 BUG: Link from sub volume, then remove the subvolume -> wrong link Goffredo Baroncelli
2009-12-12  0:24 ` TARUISI Hiroaki
2009-12-12 13:54   ` Goffredo Baroncelli
2009-12-12 18:39   ` Andy Lutomirski
2009-12-13 23:42     ` TARUISI Hiroaki
2009-12-14 18:43       ` Andrew Lutomirski
2009-12-15  0:15         ` TARUISI Hiroaki
2009-12-15  4:04           ` Andy Lutomirski [this message]
2009-12-15 17:31             ` David Nicol
2009-12-17  0:00               ` TARUISI Hiroaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B270ABE.5090109@myrealbox.com \
    --to=luto@myrealbox.com \
    --cc=chris.mason@oracle.com \
    --cc=kreijack@libero.it \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=taruishi.hiroak@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox