* [PATCH 2/3] btrfs-progs: Avoid uninitialized variant compile warning
@ 2010-03-25 12:39 Miao Xie
0 siblings, 0 replies; only message in thread
From: Miao Xie @ 2010-03-25 12:39 UTC (permalink / raw)
To: Chris Mason; +Cc: Linux Btrfs
From: Zhao Lei <zhaolei@cn.fujitsu.com>
When we compile btrfs-progs in RHEL5(with default gcc version 4.1.2 20070626),
we can get following error:
cc1: warnings being treated as errors
btrfs-list.c: In function 'find_updated_files':
btrfs-list.c:668: warning: 'disk_offset' may be used uninitialized in this function
btrfs-list.c:667: warning: 'disk_start' may be used uninitialized in this function
btrfs-list.c:666: warning: 'len' may be used uninitialized in this function
make: *** [btrfs-list.o] Error 1
These varient are always initialized except inconsistent data in file system.
We can set initial value for these variant for this situation.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
---
btrfs-list.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/btrfs-list.c b/btrfs-list.c
index 9dedb5d..112bed2 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -663,9 +663,9 @@ static int print_one_extent(int fd, struct btrfs_ioctl_search_header *sh,
char **cache_dir_name, u64 *cache_ino,
char **cache_full_name)
{
- u64 len;
- u64 disk_start;
- u64 disk_offset;
+ u64 len = 0;
+ u64 disk_start = 0;
+ u64 disk_offset = 0;
u8 type;
int compressed = 0;
int flags = 0;
--
1.6.5.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-25 12:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-25 12:39 [PATCH 2/3] btrfs-progs: Avoid uninitialized variant compile warning Miao Xie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).