* [PATCH] Btrfs-progs: fix incompat flags
@ 2010-04-01 19:17 Josef Bacik
2010-04-02 6:10 ` Tao Ma
0 siblings, 1 reply; 2+ messages in thread
From: Josef Bacik @ 2010-04-01 19:17 UTC (permalink / raw)
To: linux-btrfs
I forgot to add BTRFS_FEATURE_INCOMPAT_DEFAULT_SUBVOL to the incompat flags in
btrfs-progs. This adds it so that our tools don't freak out when touching a fs
with the default subvolume changed. Thanks,
Signed-off-by: Josef Bacik <josef@redhat.com>
---
ctree.h | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/ctree.h b/ctree.h
index 64ecf12..b79e238 100644
--- a/ctree.h
+++ b/ctree.h
@@ -350,11 +350,13 @@ struct btrfs_super_block {
* ones specified below then we will fail to mount
*/
#define BTRFS_FEATURE_INCOMPAT_MIXED_BACKREF (1ULL << 0)
+#define BTRFS_FEATURE_INCOMPAT_DEFAULT_SUBVOL (2ULL << 0)
#define BTRFS_FEATURE_COMPAT_SUPP 0ULL
#define BTRFS_FEATURE_COMPAT_RO_SUPP 0ULL
#define BTRFS_FEATURE_INCOMPAT_SUPP \
- BTRFS_FEATURE_INCOMPAT_MIXED_BACKREF
+ (BTRFS_FEATURE_INCOMPAT_MIXED_BACKREF | \
+ BTRFS_FEATURE_INCOMPAT_DEFAULT_SUBVOL)
/*
* A leaf is full of items. offset and size tell us where to find
--
1.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Btrfs-progs: fix incompat flags
2010-04-01 19:17 [PATCH] Btrfs-progs: fix incompat flags Josef Bacik
@ 2010-04-02 6:10 ` Tao Ma
0 siblings, 0 replies; 2+ messages in thread
From: Tao Ma @ 2010-04-02 6:10 UTC (permalink / raw)
To: Josef Bacik; +Cc: linux-btrfs
Hi Josef,
Josef Bacik wrote:
> I forgot to add BTRFS_FEATURE_INCOMPAT_DEFAULT_SUBVOL to the incompat flags in
> btrfs-progs. This adds it so that our tools don't freak out when touching a fs
> with the default subvolume changed. Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>
> ---
> ctree.h | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/ctree.h b/ctree.h
> index 64ecf12..b79e238 100644
> --- a/ctree.h
> +++ b/ctree.h
> @@ -350,11 +350,13 @@ struct btrfs_super_block {
> * ones specified below then we will fail to mount
> */
> #define BTRFS_FEATURE_INCOMPAT_MIXED_BACKREF (1ULL << 0)
> +#define BTRFS_FEATURE_INCOMPAT_DEFAULT_SUBVOL (2ULL << 0)
I am not familiar with btrfs, but I guess the natural way is
+#define BTRFS_FEATURE_INCOMPAT_DEFAULT_SUBVOL (1ULL << 1) ?
>
> #define BTRFS_FEATURE_COMPAT_SUPP 0ULL
> #define BTRFS_FEATURE_COMPAT_RO_SUPP 0ULL
> #define BTRFS_FEATURE_INCOMPAT_SUPP \
> - BTRFS_FEATURE_INCOMPAT_MIXED_BACKREF
> + (BTRFS_FEATURE_INCOMPAT_MIXED_BACKREF | \
> + BTRFS_FEATURE_INCOMPAT_DEFAULT_SUBVOL)
>
> /*
> * A leaf is full of items. offset and size tell us where to find
Regards,
Tao
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-02 6:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-01 19:17 [PATCH] Btrfs-progs: fix incompat flags Josef Bacik
2010-04-02 6:10 ` Tao Ma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).