From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Philipp Subject: Re: [PATCH][btrfs progs] Update/clean up btrfs help and man page Date: Sat, 09 Oct 2010 15:46:28 +0200 Message-ID: <4CB07234.1080102@gmail.com> References: <201009132124.09118.kreijack@libero.it> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: kreijack@libero.it To: linux-btrfs@vger.kernel.org Return-path: In-Reply-To: <201009132124.09118.kreijack@libero.it> List-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Today I pulled btrfs-progs-unstable from git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs-unstable.git and I found the patch from below still not applied. Is there a reason for this? Regards, Andreas Philipp On 13.09.2010 21:23, Goffredo Baroncelli wrote: > Hi all, > > enclose you can find a patch which improve the help of the btrfs > commands and its man page. Regarding the help of the btrfs > command: - moved the "subvolume set-default" command in the > "subvolume" commands group - removed a wrong new line > > Regarding the btrfs command man page: - renaming the command > "device balance" in "filesystem balance" (thanks to Andrea Phillipp > to highlight that) - adding the entry "subvolume find-new" > > Chris, you can pull the patch from the branch "help_cleanup" of the > following repository. > > http://cassiopea.homelinux.net/git/btrfs-progs-unstable-all.git > > The patch is very simple: only update the man page and move some > lines in the help of btrfs command. Comments are welcome. > > Regards G.Baroncelli > > > diff --git a/btrfs.c b/btrfs.c index ab5e57f..1816597 100644 --- > a/btrfs.c +++ b/btrfs.c @@ -61,6 +61,11 @@ static struct Command > commands[] = { { do_subvol_list, 1, "subvolume list", "\n" > "List the snapshot/subvolume of a filesystem." }, + { > do_set_default_subvol, 2, + "subvolume set-default", " > \n" + "Set the subvolume of the filesystem which will > be mounted\n" + "as default." + }, { do_find_newer, 2, "subvolume > find-new", " \n" "List the recently modified files > in a filesystem." }, @@ -68,11 +73,6 @@ static struct Command > commands[] = { "filesystem defragment", "[-vcf] [-s start] [-l len] > [-t size] | [|...]\n" "Defragment a file or a > directory." }, - { do_set_default_subvol, 2, - "subvolume > set-default", " \n" - "Set the subvolume of the > filesystem which will be mounted\n" - "as default." - }, { > do_fssync, 1, "filesystem sync", "\n" "Force a sync on the > filesystem ." @@ -89,7 +89,7 @@ static struct Command > commands[] = { }, { do_df_filesystem, 1, "filesystem df", > "\n" - "Show space usage information for a mount point\n." + > "Show space usage information for a mount point." }, { do_balance, > 1, "filesystem balance", "\n" diff --git a/man/btrfs.8.in > b/man/btrfs.8.in index 26ef982..249426c 100644 --- > a/man/btrfs.8.in +++ b/man/btrfs.8.in @@ -15,6 +15,10 @@ btrfs \- > control a btrfs filesystem .PP \fBbtrfs\fP \fBsubvolume > set-default\fP\fI \fP .PP +\fBbtrfs\fP \fBsubvolume > find-new\fP\fI \fP +.PP +\fBbtrfs\fP > \fBfilesystem balance\fP\fI \fP +.PP \fBbtrfs\fP > \fBfilesystem defrag\fP\fI | [|...]\fP .PP > \fBbtrfs\fP \fBfilesystem sync\fP\fI \fP @@ -25,8 +29,6 @@ > btrfs \- control a btrfs filesystem .PP \fBbtrfs\fP \fBdevice > show\fP\fI |