linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: C Anthony Risinger <anthony@extof.me>
Cc: Chris Mason <chris.mason@oracle.com>,
	Mitch Harder <mitch.harder@sabayonlinux.org>,
	linux-btrfs@vger.kernel.org
Subject: Re: [GIT PULL][PATCH v2 0/6] btrfs: Add lzo compression support
Date: Tue, 30 Nov 2010 09:00:05 +0800	[thread overview]
Message-ID: <4CF44C95.6020908@cn.fujitsu.com> (raw)
In-Reply-To: <AANLkTin4VPOXBOU9fM5CVqSSnwMMrUCoDqoYu5mKWXLL@mail.gmail.com>

C Anthony Risinger wrote:
> On Wed, Nov 17, 2010 at 8:08 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> Hi Chris,
>>
>> Here's the updated patchset. As I still haven't got a kernel.org
>> account, I have set up a git tree in another public git repository,
>> and I'll use it for now.
>>
>> You can pull from:
>>
>>        git://repo.or.cz/linux-btrfs-devel.git lzo-support
>>
>>
>> Lzo is a much faster compression algorithm than gzib, so would allow
>> more users to enable transparent compression, and some users can
>> choose from compression ratio and compression speed.
>>
>> Usage:
>>
>> # mount -t btrfs -o compress[=<zlib,lzo>] dev /mnt
>> or
>> # mount -t btrfs -o compress-force[=<zlib,lzo>] dev /mnt
>>
>> "-o compress" without argument is still allowed for compatability.
>>
>> Compatibility:
>>
>> If we mount a filesystem with lzo compression, it will not be able be
>> mounted in old kernels. One reason is, otherwise btrfs will directly
>> dump compressed data, which sits in inline extent, to user.
>>
>> Performance:
>>
>> The test copied a linux source tarball (~400M) from an ext4 partition
>> to the btrfs partition, and then extracted the tarball.
>>
>> (time in second)
>>           lzo        zlib        nocompress
>> copy:      10.6       21.7        14.9
>> extract:   70.1       94.4        66.6
>>
>> (data size in MB)
>>           lzo        zlib        nocompress
>> copy:      185.87     108.69      394.49
>> extract:   193.80     132.36      381.21
>>
>> Test:
>>
>> Mitch has tested the patchset, and provided some positive feedback.
>> According to him, the patchset works as expected and nothing bad
>> has he experienced.
>>
>> Other:
>>
>> The defrag ioctl is also updated, so one can choose lzo or zlib when
>> turning on compression in defrag operation.
>>
>> Main change from v1:
>>
>> - Add incompat flag.
>> - Fix build issue by selecting kernel lzo module.
>> - Check compression type in defrag ioctl.
>>
>> ---------------->
>> Li Zefan (6):
>>      btrfs: Fix bugs in zlib workspace
>>      btrfs: Fix error handling in zlib
>>      btrfs: Allow to add new compression algorithm
>>      btrfs: Add lzo compression support
>>      btrfs: Allow to specify compress method when defrag
>>      btrfs: Extract duplicate decompress code
>>
>>  fs/btrfs/Makefile       |    2 +-
>>  fs/btrfs/btrfs_inode.h  |    2 +-
>>  fs/btrfs/compression.c  |  329 +++++++++++++++++++++++++++++++++++++-
>>  fs/btrfs/compression.h  |   72 ++++++--
>>  fs/btrfs/ctree.h        |   11 +-
>>  fs/btrfs/extent_io.c    |    5 +-
>>  fs/btrfs/extent_io.h    |   17 ++-
>>  fs/btrfs/extent_map.c   |    2 +
>>  fs/btrfs/extent_map.h   |    3 +-
>>  fs/btrfs/file.c         |    2 +
>>  fs/btrfs/inode.c        |   82 ++++++----
>>  fs/btrfs/ioctl.c        |   10 +-
>>  fs/btrfs/ioctl.h        |    9 +-
>>  fs/btrfs/lzo.c          |  409 +++++++++++++++++++++++++++++++++++++++++++++++
>>  fs/btrfs/ordered-data.c |   18 ++-
>>  fs/btrfs/ordered-data.h |    8 +-
>>  fs/btrfs/super.c        |   47 +++++-
>>  fs/btrfs/zlib.c         |  361 +++++++----------------------------------
>>  18 files changed, 1013 insertions(+), 376 deletions(-)
> 
> is this in a branch somewhere?  or for inclusion in .37/.38?  this is
> a very attractive feature.
> 
> what's the proper place (repo/branch) to see what is pending?
> 

As a new feature, it's too late for .37. Hope to see it merged in .38
merge window.

Chris' btrfs-unstable git tree is the "official" place to see what is
pending, but just he hasn't picked up those patches, so for now it
only sits in my own tree.

  reply	other threads:[~2010-11-30  1:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18  2:08 [GIT PULL][PATCH v2 0/6] btrfs: Add lzo compression support Li Zefan
2010-11-18  2:09 ` [PATCH v2 1/6] btrfs: Fix bugs in zlib workspace Li Zefan
2010-11-18  2:10 ` [PATCH v2 2/6] btrfs: Fix error handling in zlib Li Zefan
2010-11-18  2:10 ` [PATCH v2 3/6] btrfs: Allow to add new compression algorithm Li Zefan
2010-11-18  2:10 ` [PATCH v2 4/6] btrfs: Add lzo compression support Li Zefan
2010-11-18  2:11 ` [PATCH v2 5/6] btrfs: Allow to specify compress method when defrag Li Zefan
2010-11-18  2:11 ` [PATCH v2 6/6] btrfs: Extract duplicate decompress code Li Zefan
2010-11-29 17:54 ` [GIT PULL][PATCH v2 0/6] btrfs: Add lzo compression support C Anthony Risinger
2010-11-30  1:00   ` Li Zefan [this message]
2010-11-30 17:12     ` C Anthony Risinger
2010-12-01  1:02       ` Li Zefan
2010-12-24  5:35 ` cwillu
2010-12-24  6:55   ` Li Zefan
2010-12-24 12:32     ` Chris Mason
2010-12-24 20:45       ` Chris Mason
2010-12-26  3:31         ` C Anthony Risinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF44C95.6020908@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=anthony@extof.me \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=mitch.harder@sabayonlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).